Milestone Delivery: Escrow pallet Milestone #1 by herou · Pull Request #566 · w3f/Grant-Milestone-Delivery

herou · 2022-09-09T16:08:54Z

Milestone Delivery Checklist

The milestone-delivery-template.md has been copied and updated.
The invoice form 📝 has been filled out for this milestone.
This pull request is being made by the same account as the accepted application.
In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1094

takahser · 2022-09-13T14:58:19Z

@herou thanks for your delivery! We currently have a rather large backlog to tackle, so it might take a bit longer than usual until your delivery is evaluated. Nevertheless, we're going to take a look at it as soon as we can.

keeganquigley · 2022-09-15T16:31:41Z

Hi @herou I have started the process of evaluating your milestone. Please give me a bit of time to fully understand your project and I will reach out to you with any questions I may have. Thanks!

keeganquigley · 2022-09-15T20:39:38Z

@herou I looked over your milestone and am getting 404 errors on Deliverable 4. Docker and 6. Escrow Pallet. Can you fix these links? Thanks!

herou · 2022-09-15T20:57:26Z

@herou I looked over your milestone and am getting 404 errors on Deliverable 4. Docker and 6. Escrow Pallet. Can you fix these links? Thanks!

It should be fine now. I made my repo public.

keeganquigley · 2022-09-16T05:02:48Z

Thanks @herou a couple more things to address:

Can you provide a link to the license file? This will be needed for submission.
Is there a reason the license file is in the master branch and the rest of the pallet is in eljo-prifti/escrow?

herou · 2022-09-16T12:52:03Z

Thanks @herou a couple more things to address:

Can you provide a link to the license file? This will be needed for submission.

Is there a reason the license file is in the master branch and the rest of the pallet is in eljo-prifti/escrow?

Here it is: https://github.com/herou/EscrowPallet/blob/eljo-prifti/escrow/LICENSE

herou · 2022-09-16T17:27:49Z

Thanks @herou however I was actually asking if you can update this on the milestone delivery itself. Right now it just says Apache 2.0 but doesn't link to it. Sorry for the confusion there. Can you update this?

I added it to the milestone delivery doc.

keeganquigley · 2022-09-16T22:09:38Z

Thanks @herou moving on, your pallet code looks good and the unit tests are all successful. However, some of the benchmarking tests are failing when running cargo test --features runtime-benchmarks. Are you able to address these 2 errors?

  error[E0425]: cannot find function `assert_last_event` in this scope
    --> /Users/keeganquigley/EscrowPallet/pallets/escrow/src/benchmarking.rs:30:3
     |
  30 |      assert_last_event::<T>(Event::Locked(caller, amount).into());
     |      ^^^^^^^^^^^^^^^^^ not found in this scope

     Compiling frame-system-benchmarking v4.0.0-dev (https://github.com/paritytech/substrate.git?branch=polkadot-v0.9.28#34a06217)
  error[E0599]: no function or associated item named `max_value` found for associated type `<<T as pallet::Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance` in the current scope
    --> /Users/keeganquigley/EscrowPallet/pallets/escrow/src/benchmarking.rs:23:32
     |
  23 |         let amount = BalanceOf::<T>::max_value();
     |                                      ^^^^^^^^^ function or associated item not found in `<<T as pallet::Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance`
     |
     = help: items from traits can only be used if the trait is in scope
  help: the following traits are implemented but not in scope; perhaps add a `use` for one of them:
     |
  3  | use frame_support::sp_runtime::traits::Bounded;
     |
  3  | use num_traits::bounds::UpperBounded;
     |
  3  | use num_traits::float::FloatCore;
     |

  Some errors have detailed explanations: E0425, E0599.
  For more information about an error, try `rustc --explain E0425`.
  warning: `escrow` (lib) generated 2 warnings
  error: could not compile `escrow` due to 2 previous errors; 2 warnings emitted
  warning: build failed, waiting for other jobs to finish...

herou · 2022-09-17T12:13:45Z

cargo test --features runtime-benchmarks

Sorry for this inconvenience, pushed my fix. Please take another look. @keeganquigley please let me know asap if this is okay because I am ready to push the second milestone. Thank you!

alxs · 2022-09-20T13:06:01Z

@herou we don't require milestones to be delivered sequentially, so feel free to create a PR for the second milestone already.

keeganquigley · 2022-09-20T14:48:17Z

Apologies for the delay @herou and thanks for fixing the benchmarking tests! The fix did work. The pallet looks good and I am finishing up my eval now.

keeganquigley · 2022-09-21T21:03:10Z

@herou apologies for the delay and thanks for your patience during this process. I'm ready to submit my evaluation, which you can find here. The only outstanding issue concerns the unit tests. Please consider adding these for the next milestone.

herou · 2022-09-21T22:21:13Z

@herou apologies for the delay and thanks for your patience during this process. I'm ready to submit my evaluation, which you can find here. The only outstanding issue concerns the unit tests. Please consider adding these for the next milestone.

Hi, thank you for your reply. NoValueStored and WrongExpiringDate are going to be used in the later milestones. If you see the sign_contract does not throw any of these errors, which means I can not write tests for them. SameAddressError error is used in the sign_contract, that's why I have written a test for it. Is it clear to you? Please, @elio.prifti:matrix.org write me directly on element if it is not clear to you. I would like to thank you for your time and effort. Thanks a lot!

keeganquigley · 2022-09-21T22:24:22Z

@herou okay thanks for clarifying! Yes in that case I am happy to accept this milestone! I have submitted the PR and will let the rest of the team know.

herou · 2022-09-21T22:26:26Z

@herou okay thanks for clarifying! Yes in that case I am happy to accept this milestone! I have submitted the PR and will let the rest of the team know.

My first milestone accepted :)

takahser · 2022-09-22T14:44:39Z

@herou could you upload a new invoice that includes your home address, please?
Also, please make sure to include the W3F's address:

Web 3.0 Technologies Foundation
Address: Baarerstrasse 14, 6300 Zug, Switzerland
UID / VAT ID: CHE-322.596.347

herou · 2022-09-22T15:47:58Z

@herou could you upload a new invoice that includes your home address, please? Also, please make sure to include the W3F's address:

Web 3.0 Technologies Foundation Address: Baarerstrasse 14, 6300 Zug, Switzerland UID / VAT ID: CHE-322.596.347

Uploaded it, please let me know if it is okay. Thank you!

takahser · 2022-09-22T20:13:13Z

@herou thanks. I think, in your address the town and country are still missing though, can you add them and re-upload?

herou · 2022-09-22T20:46:42Z

@herou thanks. I think, in your address the town and country are still missing though, can you add them and re-upload?

Can you please check it now and let me know? Thank you!

keeganquigley · 2022-09-23T21:50:41Z

@herou it looks good now, thanks!

herou · 2022-09-25T21:19:15Z

@keeganquigley I really liked your review and I would like to have a short conversation with you if possible. Can you please write me on twitter: https://mobile.twitter.com/eljoprifti1 I would really appreciate it. Looking forward to hearing from you. You rock it!

keeganquigley · 2022-09-26T21:28:57Z

@herou thanks for the compliments, and sure thing! I will DM you now.

takahser · 2022-09-27T16:43:36Z

@herou your address seems to be a tron address which we don't currently support for payouts:

Payment is made in Bitcoin, USDT, DAI or aUSD.

The amount in your grant application is denominated in USDT, which would work for us. Hence, could you please also update the wallet address?

herou · 2022-09-27T18:15:10Z

@herou your address seems to be a tron address which we don't currently support for payouts:

Payment is made in Bitcoin, USDT, DAI or aUSD.

The amount in your grant application is denominated in USDT, which would work for us. Hence, could you please also update the wallet address?

Can you please check it again?

keeganquigley · 2022-09-27T18:27:13Z

thanks @herou we received the updated invoice but can you update it in the contract as well? Thanks!

herou · 2022-09-27T18:52:52Z

thanks @herou we received the updated invoice but can you update it in the contract as well? Thanks!

It can not be done because the PR has been merged.

keeganquigley · 2022-09-27T19:07:40Z

@herou ah right, okay I will check with @takahser on how to proceed.

keeganquigley · 2022-09-27T19:13:28Z

@herou I checked with the team, and the contract will need to be amended. You can submit another PR for this. Thanks and apologies for the inconvenience.

herou · 2022-09-27T19:47:38Z

@herou I checked with the team, and the contract will need to be amended. You can submit another PR for this. Thanks and apologies for the inconvenience.

This is a new PR of changing the address: w3f/Grants-Program#1190

herou · 2022-10-04T09:01:01Z

@herou I checked with the team, and the contract will need to be amended. You can submit another PR for this. Thanks and apologies for the inconvenience.

This is a new PR of changing the address: w3f/Grants-Program#1190

Hi @keeganquigley . Can you please let me know the status of the payment of this milestone?

keeganquigley · 2022-10-10T16:13:08Z

@herou confirmed that he has received payment for the milestone, noting this here.

Add escrow-milestone_1.md file

c5f61e7

herou changed the title ~~Add escrow-milestone_1.md file~~ Milestone Delivery: Escrow pallet Milestone #1 Sep 9, 2022

herou added 20 commits September 9, 2022 18:17

Small changes

2f8a627

Fix Application doc

4fbd68a

Fix Application doc

2dfd5d9

Try to fix Application doc

07ccc46

try to fix

6b1b62e

test to pass application doc

231034c

test

7d35bd8

test

207386a

Add article

4c57407

Test

21f816a

test2

ffd2fd0

Add licencse

58fa29d

Add license

571de71

Add Documentation

acc8004

Add Docker

5777f60

Add Article

d827416

Add application document

a66726b

Add escrow pallet

184778c

Add Documentation and tutorial

75491ad

Add note for Article

e02ae51

takahser assigned takahser and unassigned takahser Sep 14, 2022

Add License link

3bd1f42

takahser assigned keeganquigley Sep 19, 2022

keeganquigley mentioned this pull request Sep 21, 2022

Create escrow-pallet_1_keeganquigley.md #572

Merged

keeganquigley merged commit 47c6f3e into w3f:master Sep 22, 2022

takahser mentioned this pull request Sep 22, 2022

Update build-open-source.md w3f/polkadot-wiki#3808

Merged

Conversation

herou commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Milestone Delivery Checklist

Uh oh!

takahser commented Sep 13, 2022

Uh oh!

keeganquigley commented Sep 15, 2022

Uh oh!

keeganquigley commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

herou commented Sep 15, 2022

Uh oh!

keeganquigley commented Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

herou commented Sep 16, 2022

Uh oh!

herou commented Sep 16, 2022

Uh oh!

keeganquigley commented Sep 16, 2022

Uh oh!

herou commented Sep 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alxs commented Sep 20, 2022

Uh oh!

keeganquigley commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keeganquigley commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

herou commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keeganquigley commented Sep 21, 2022

Uh oh!

herou commented Sep 21, 2022

Uh oh!

takahser commented Sep 22, 2022

Uh oh!

herou commented Sep 22, 2022

Uh oh!

takahser commented Sep 22, 2022

Uh oh!

herou commented Sep 22, 2022

Uh oh!

keeganquigley commented Sep 23, 2022

Uh oh!

herou commented Sep 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keeganquigley commented Sep 26, 2022

Uh oh!

takahser commented Sep 27, 2022

Uh oh!

herou commented Sep 27, 2022

Uh oh!

keeganquigley commented Sep 27, 2022

Uh oh!

herou commented Sep 27, 2022

Uh oh!

keeganquigley commented Sep 27, 2022

Uh oh!

keeganquigley commented Sep 27, 2022

Uh oh!

herou commented Sep 27, 2022

Uh oh!

herou commented Oct 4, 2022

Uh oh!

keeganquigley commented Oct 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

herou commented Sep 9, 2022 •

edited

Loading

keeganquigley commented Sep 15, 2022 •

edited

Loading

keeganquigley commented Sep 16, 2022 •

edited

Loading

herou commented Sep 17, 2022 •

edited

Loading

keeganquigley commented Sep 20, 2022 •

edited

Loading

keeganquigley commented Sep 21, 2022 •

edited

Loading

herou commented Sep 21, 2022 •

edited

Loading

herou commented Sep 25, 2022 •

edited

Loading