Tesseract dApp/Wallet Connection: milestone #1

[dileping]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#508.

[Noc2]

Sorry for the delay here. We had a couple of internal changes, people being sick and business trips that caused a big delay. We will try to evaluate your deliveries as soon as possible.

[dileping]

@Noc2 Thanks for getting back on this. No worries. We are moving full speed ahead with the next milestone. Already have have a working solution on Android and now are integrating it with the Rust Core. Though, we'd really like to move ahead with marketing and publish the articles.

[Noc2]

Sorry again for the late reply. I finally started to look into the delivery, but when I run cargo +nightly run, I get the following message: https://github.com/w3f/Grant-Milestone-Delivery/blob/master/evaluations/mobile_dapp_connection_1_Noc2.md#general-notes Could you look into this?

[dileping]

@Noc2 thanks for starting the review. Already accepted your change to our README.MD - totally forgot about nightly as it was set by default in my environment.

As for the output - it's correct and works properly, displaying two requests/responses done :) one is a successful response, and another one is an intentional error (when the wallet produces an error) made to demonstrate the ability of the protocol to transfer the errors properly.

So here is some explanation:

The output line starting with @@@WOW@@@ (yes, I was that happy to see the response finally) is printing the response to the request made by line
let signed = Arc::clone(&client_service).sign_transaction("testTransaction");
The piece _signed! is added by the wallet side and thus we can see that the transfer went through the whole stack properly.

The output line starting with !!!!UGH!!!! is the line that prints an intended error. The wallet-side is implemented the way that make_error "transaction" is a special case that produces an error for the test purposes.

If you think we need to improve the output and make it more clear, please, let me know. We just didn't bother with it much, but rather kept it understandable for us so that we could test the protocol stack.

Also, I just noticed that in you review the Application Document and Kusama Identity are probably from different project. Our Application Document is https://github.com/w3f/Grants-Program/blob/master/applications/mobile_dapp_connection.md and we didn't provide any Kusama Identity.

[Noc2]

Thanks for pointing out that I was linking to the wrong application and already merging my PR. I’m happy to tell you that the milestone is a pass and I will forward your invoice internally. My only comment regarding the above would be that it’s not super user friendly ;-)

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

[dileping]

@Noc2 thanks for accepting the milestone!

As for not super user friendly, do you mean the test app or the APIs? If the latter, could you, please, provide us with some details? We'll appreciate your feedback a lot and would love to improve based on that.

[Noc2]

Hi. I was referring to the output above: @@@wow@@@ and !!!!UGH!!!! are not the most common terms ;-)

[dileping]

@Noc2 glad to hear it's just that. Thank you!