add dotpay milestone 1

[AdaLam7]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#715

[Noc2]

Thanks for the delivery. We will look into it as soon as possible.

[Noc2]

I finally started to look into your delivery. You can find my evaluation here. Could you take a look at it and let me know in case you have any questions?

[AdaLam7]

Thanks for your feedback, we will make changes based on your suggestions.

[AdaLam7]

Sorry for the previous delivery issue. We have updated based on your comments.

0b Can’t access the documentation or see anything without login via github and sharing my data.

Now you don't need login to access the docs.

0c Only description on how to run tests inside docker.

Add test from source code, and we fixed docker test failed issue.

1 Docker set up doesn't seem to work for me, see below. http://bytepay.local-dev.host/ doesn't open

We update the README, and now you can use http://localhost:10086/ to access the local website.

08.02.22: Test fail, the contract seems mostly to be a copy of contract-transfer. The documentation should be updated at least

We update the contract documentation. But the contract has two unit tests failed caused by canvas UI and the ink! itself, see more detail about the issue: use-ink/ink#1117

If you want to use dotpay, you must log in to the system(locally or https://bytepay.online).

[AdaLam7]

We have fixed all deliverables~ please check out 😃 ~

[sulnong]

Notice: Please pull code before test~

[Noc2]

Sorry for the delay here and thanks for the changes. I just updated my evaluation. I was now able to test the docker version, but it would be nice to also have a way to set up everything locally. For example, the docker version showed me a substrate address, but I’m not sure how I can connect to the chain and fund this substrate address for testing. Additionally, I found it strange that the live version already works with DOTs. This means the smart contract is not used or can you point to the place where it’s integrated. Also where in the backend is the data stored and the address generated? Could you share links to the actual implementation with me? Thanks!

[AdaLam7]

@Noc2 thanks for the review.

it would be nice to also have a way to set up everything locally

We will provide it soon~

I’m not sure how I can connect to the chain and fund this substrate address for testing

Now we use Westend for testing now, the local chain only tests for the contract.

This means the smart contract is not used

• Yes, the live version works now but not used contract now. Because the Polkadot parallel chain does not currently support ink!. Now the contract can only run tests individually and will be integrated in the future.

• The Polkadot ink! contract test local has some issue caused by ink itself and canvas, see know issue

Also wherein the backend is the data stored and the address generated?

All the data is now stored in our MongoDB, and we back up the database in real-time. The most important data is the project owner mnemonic, we store it now and will disable it when ink! works in feature.

code link

By the way, the bytepay project is developed on faas platform named laf which is our own open-source project.

[AdaLam7]

1. Save the owner account info in the database now, not save developer mnemonic if they bind address. keyring code link
2. webhook source code
3. Adress binding source code
4. The live version is polkadot address. Maybe caused by the docker image not upgrade, we will update it.
   
   Just transfer to the account to recharge like using QRcode:
   

[Noc2]

Thanks for the super quick reply here and providing the links to the code. Makes sense. Let me know once you added a description on how to run things locally without docker and you updated the docker image. Ideally at least the local version would run with the smart contract, but I understand that this currently doesn’t seem to be your fault. Therefore it won’t be necessary for the approval of this milestone.

[AdaLam7]

Shows a substrate account instead of a polkakdot address, not sure how to fund this account

We already fixed it and update the docker image. Now local will show polkadot address.

Also now you can run frontend and backend using docker-compose: https://github.com/bytepayment/bytepay#run-all-in-local-mode it also contains mongo. But the project also needs Interact with github，so the webhook will not work because github can't access your local server.

added a description on how to run things locally without docker

We have a lot of dependencies, it might be more complicated not to use docker, is it possible to provide a Dockerfile to describe the way to run locally, since the two are almost the same.

[Noc2]

Thanks again for the update. A transparent Dockerfile that describes the way to run it locally is fine. But when I run “ docker-compose up”, I currently get the following error:

sudo docker-compose up
Starting bytepay_bytepay_1 ... done
Attaching to bytepay_bytepay_1
bytepay_1  | /docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
bytepay_1  | /docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
bytepay_1  | /docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
bytepay_1  | 10-listen-on-ipv6-by-default.sh: info: IPv6 listen already enabled
bytepay_1  | /docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
bytepay_1  | /docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
bytepay_1  | /docker-entrypoint.sh: Configuration complete; ready for start up
bytepay_1  | 2022/02/17 12:55:28 [emerg] 1#1: cannot load certificate "/cert/bytepay.online.fullchain.pem": BIO_new_file() failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/cert/bytepay.online.fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)
bytepay_1  | nginx: [emerg] cannot load certificate "/cert/bytepay.online.fullchain.pem": BIO_new_file() failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/cert/bytepay.online.fullchain.pem','r') error:2006D080:BIO routines:BIO_new_file:no such file)
bytepay_bytepay_1 exited with code 1

[sulnong]

@Noc2
Seems this error is caused by old version compose file.
We update compose file, please pull the code and check again :)

[Noc2]

Indeed, it works now. I can confirm that the milestone is a pass and I will forward your invoice internally.

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

[AdaLam7]

@Noc2 Thanks very much, our team is very excited about the successful merge.

By the way, As part of the grant program, we allow everyone to participate in the evaluation process of submitted milestones. Successfully merged external evaluations will receive up to 2 KSM, If bytepay support Kusama, Will you consider using bytepay to pay for developer KSM? web3 foundation will be the first user of bytepay, give us more suggestions in the use, and help bytepay get a better user experience. I believe that bytepay will also make the foundation's Pay easier

[Noc2]

Thanks for the suggestions, I will bring it up internally. But we might have reservations about it because of the centralization of it right now and our security team probably would require us to host it ourselves.

[AdaLam7]

Indeed, it works now. I can confirm that the milestone is a pass and I will forward your invoice internally.

@Noc2 We have submitted the invoice via the form, it has been two weeks, and have not received the M1 funding, just wondering if we are missing something？

[Noc2]

Thanks for chasing us. I just pinged the invoice team about it.

[RouvenP]

hi @AdaLam7 apologies for the delay. The transfer will be executed tomorrow. We will notify you as soon as done.

[RouvenP]

hi @AdaLam7, we transferred the payment today. Thanks!