Candle Auction on Ink!: Milestone-2 delivered

[agryaznov]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#666 < please fill this in with the PR number of your application.

[mmagician]

Thanks for the delivery! We'll check it as soon as we can :)

[semuelle]

Hey Alexander. Sorry for the late reply. We have a bit of a backlog.

I have looked at all your deliverables, and everything looks great. The only issue I have is that I am unable to deploy the contract locally. Whatever node I'm using, I get PortableRegistry: 1: Error extracting {"path":[],"params":[],"def":{"composite":{"fields":[]}},"docs":[]}: n[0] is undefined when trying to upload the contract. Any idea what's going on?

[agryaznov]

Hi Sebastian! I'm seeing this error for the first time. Could you please provide more info for me to try to reproduce it?:

1. Are you getting this while deploying candle_auction.contract or erc271.contract as well?
2. How are you trying to deploy it - through PolkadotJS Apps?
3. Which build are you deploying - the one you've built yourself or the one which is attached to the release?

[semuelle]

1. both
2. yes
3. the one I built myself

I will try and deploy the one in the release, perhaps that changes anything. Which Rust toolchain and contracts-node versions do you use?

[agryaznov]

My env:

$ substrate-contracts-node --version
substrate-contracts-node 0.1.0-7d81166-x86_64-linux-gnu
$ cargo-contract --version
cargo-contract 0.16.0-unknown-x86_64-linux-gnu
$ rustc +nightly --version
rustc 1.59.0-nightly (532d2b14c 2021-12-03)
$ cargo +nightly --version 
cargo 1.58.0-nightly (294967c53 2021-11-29)

I have just re-checked, it builds and being deployed fine

[semuelle]

Okay, got it working. That took an unreasonable amount of time, but it looks like it was first an outdated cargo-contract, and then some incompatibilities between the cargo-contract and substrate-contracts-node.

Your milestone is hereby accepted. Great work overall. The only issue I could find was that, in the README, getWinner should be getWinning. Evaluation notes are here.

I will forward your invoice for processing. See you for Milestone 3. :)

[agryaznov]

The only issue I could find was that, in the README, getWinner should be getWinning.

Correct. Fixed this one.

Thanks Sebastian!

[RouvenP]

hi @agryaznov we transferred the payment. Thanks!