Openbrush Milestone 1

[0xMarkian]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#497

This milestone was sponsored by Supercolony. So there will be no invoice for it.

[semuelle]

Thank you for the delivery, @themarkian. We will look into it as soon as possible.

[semuelle]

Thanks again for the delivery, @themarkian. I pushed my evaluation notes and your milestone is hereby accepted. 🎉

As you can see, I don't have many comments. The code looks good, and the documentation was easy to follow. As a developer, I would probably expect more unit tests, but it's sufficient for this milestone.

I am following the discussion on the ink! PR you made, and the consensus seems that it won't be merged. With regard to the next milestone, do you already know what the strategy will be? Your own ink! fork would certainly not be a desirable outcome.

[xgreenx]

Thank you for feedback=)

I am following the discussion on the ink! PR you made, and the consensus seems that it won't be merged. With regard to the next milestone, do you already know what the strategy will be? Your own ink! fork would certainly not be a desirable outcome.

Yes, the conversation is still in progress about this PR. If the PR is not merged, it will not be a critical problem, because we need this feature only for the second and the third milestones. So we will use our version of ink! and we will integrate all changes from the original ink! during these two milestones.

In the scope of the fourth milestone, we want to help to ink! team to have the full support of traits on ink! level. So after implementation of it in ink! we can switch back to the original ink!.

Of course, we prefer to integrate this change to ink! but it is not a blocker.