NeuroZK Milestone 1

[beekay2706]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2393

[keeganquigley]

Hi @beekay2706 sorry for the delay, we were catching up from the holidays. Currently the node is failing to build when running cargo build --release --features ocw:

cargo build --release --features ocw
error: failed to load manifest for workspace member `/home/ubuntu/cyborg-parachain/node`
referenced by workspace at `/home/ubuntu/cyborg-parachain/Cargo.toml`

Caused by:
  failed to load manifest for dependency `cyborg-runtime`

Caused by:
  failed to load manifest for dependency `cyborg-primitives`

Caused by:
  failed to load manifest for dependency `orml-oracle`

Caused by:
  failed to read `/home/ubuntu/cyborg-parachain/orml/oracle/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

Should I be using the main branch? cargo test or any other command doesn't work either. It also happens in each individual pallet folder. Could you fix this? Here's my setup:

rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/ubuntu/.rustup

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu (default)
nightly-x86_64-unknown-linux-gnu

active toolchain
----------------

stable-x86_64-unknown-linux-gnu (default)
rustc 1.84.0 (9fc6b4312 2025-01-07)

[beekay2706]

Thank you for your response, @keeganquigley

We have updated the parachain's README file to reflect recent changes. Notably, we no longer utilize off-chain workers, rendering the ocw flag obsolete. For testing purposes, please continue to use the master branch, which we reviewed again today. The README now directs you to the correct testing documentation.

Please check and revert

[keeganquigley]

Thanks @beekay2706 the unit tests are passing now. A few additional questions:

• What is the main reason for choosing a symlink to manage the ORML dep instead of a submodule? I've never seen this type of setup for a parachain before. Is it just for testing purposes?
• How will you handle testing of runtime upgrades, given that the symlink might point to different versions of ORML on different machines? How will you ensure that all validators build the exact same runtime binary during an upgrade?
• Submodules are typically the standard because they pin deps to specific Git commits to ensure that builds stay reproducible. It seems to me that a symlink might introduce non-determinism. For example what happens when the library is updated?

[beekay2706]

Thanks for getting back to me so quickly, @keeganquigley

We have indeed used a submodule that links to the specific commit we are using. Are you suggesting that we also include that specific branch in the Cargo.toml file? Please correct me if I'm wrong.

[keeganquigley]

Ah thanks @beekay2706 for the clarification, great, the hash confirms it so no worries. I should have inspected it locally, the way GH displays it on the web interface threw me off. Your set up was correct though. Happy to pass the milestone. Here is my final evaluation. Cheers.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.