-
Notifications
You must be signed in to change notification settings - Fork 63
TD Figures Update #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD Figures Update #1913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @egekorkan! Just two tiny nits: It seems to me as if sometimes a space is missing between (Array of)
and the respective type. Also, sometimes, the Array of
in parentheses is italicized, and sometimes not.
This PR just updates the Figures so that they are in sync with Chapter 5.3. Approve this PR |
@JKRhb I have addressed your feedback. If it can be an array or string (e.g. I will also beautify the Thing diagram to remove weird placement of arrows. |
The Thing diagram is also updated. For preview, you can use the following URL: https://cdn.statically.io/gh/w3c/wot-thing-description/ege-image-update/publication/ver11/7-rec/Overview.html#namespaces |
Met during main call, felt there were still some things to fix and we wanted a summary of the changes (we looked through the figures but it was hard to see exactly what changed due to the changes in layout). So we decided to make a resolution in the main call to give the TD editors the authority to make the necessary changes to the figures prior to REC transition. Ideally you would finalize this tomorrow in the TD coordination call. I would be good to write a summary of the changes somewhere, however, e.g. "string changed to langString in title and description", "href added to Link and Form", etc. As for reviews, I noticed in some places that "any type" is not formatted in black but I think it should be. Also I don't think "subclass" arrows should go downward as a general rule, but I can live with the new layout. However, as above, the group is giving you the authority to finalize this and you should do it as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would have been good to see a summary of changes, but ok to publish, some minor points noted elsewhere
The changes are done to the publication folder SVG files. These are: Thing (td.svg)
Data Schema (jsonschema.svg)
Security (wotsec.svg)
Hypermedia Control (hctl.svg)
|
There are some misalignments in the figures that are autogenerated and exported into png. I have fixed them in SVGs manually given the publication procedure but the toolchain should be fixed later on.
What I have done to generate the results:
Status: