Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema links to static ones #1870

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix schema links to static ones #1870

merged 1 commit into from
Aug 30, 2023

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented Aug 8, 2023

We should fix these notes. My proposal is to merge this and #1861 together and decide on where to serve the content from. It doesn't matter if the schemas come from a new repo, a GitHub release or the publication folder but these links should appear in the REC.


Preview | Diff

@egekorkan egekorkan added Editorial Issues with no technical impact on implementations by REC publication changes index.html a PR that changes the index.html text labels Aug 8, 2023
@egekorkan egekorkan requested review from relu91 and sebastiankb August 8, 2023 22:43
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we to update the $id here too?

Update: ah probably is it something that we have to change when we decide on the mechanism in #1861

@egekorkan
Copy link
Contributor Author

Don't we to update the $id here too?

Update: ah probably is it something that we have to change when we decide on the mechanism in #1861

So I would try to keep the PRs focused for now. This one changes the index.html and once we agree on the link, we can change the resource behind it easily (where the $id will be present)

@egekorkan
Copy link
Contributor Author

@egekorkan egekorkan merged commit 3564b5f into main Aug 30, 2023
@egekorkan egekorkan deleted the ege-static-links branch February 21, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by REC publication changes index.html a PR that changes the index.html text Changes to PR HTML Editorial Issues with no technical impact on implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants