Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 44 fix #1845

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Example 44 fix #1845

merged 2 commits into from
Aug 30, 2023

Conversation

sebastiankb
Copy link
Contributor

@sebastiankb sebastiankb commented Jul 6, 2023 •
edited by pr-preview bot
Loading

there is a wrong semantic reference used in Example 44:

"@context": [
...
      "om": "http://www.ontology-of-units-of-measure.org/resource/om-2/",
...
"unit": "om:degree_Celsius",
...

Correct should be:

"@context": [
...
      "om": "http://www.ontology-of-units-of-measure.org/resource/om-2/",
...
"unit": "om:degreeCelsius",
...

Also see

http://www.ontology-of-units-of-measure.org/resource/om-2/degreeCelsius

Preview | Diff

danielpeintner
danielpeintner approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

based on http://www.ontology-of-units-of-measure.org/resource/om-2/degreeCelsius

@sebastiankb sebastiankb added the Editorial Issues with no technical impact on implementations label Jul 7, 2023
relu91
relu91 approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 🟩

@egekorkan
Copy link
Contributor

Call of 12.07:

  • This is an oversight and a bug fix
  • We are not doing semantic validation and it would be good to have automation for it
  • The TF is ok to merge it. We will need a group resolution.

@egekorkan egekorkan mentioned this pull request Jul 12, 2023
Open
@egekorkan egekorkan added the changes index.html a PR that changes the index.html text label Aug 2, 2023
@egekorkan
Copy link
Contributor

Merging as communicated at https://lists.w3.org/Archives/Member/member-wot-wg/2023Aug/0003.html

@egekorkan egekorkan merged commit 76e1da4 into main Aug 30, 2023
@egekorkan egekorkan deleted the Example44-fix branch August 30, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@danielpeintner danielpeintner danielpeintner approved these changes

@egekorkan egekorkan Awaiting requested review from egekorkan

@mjkoster mjkoster Awaiting requested review from mjkoster

Assignees
No one assigned
Labels
by REC publication changes index.html a PR that changes the index.html text Changes to PR HTML Editorial Issues with no technical impact on implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebastiankb @egekorkan @relu91 @danielpeintner @mmccool