Generate types for unreachable definitions #372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w3c/wot-thing-description#1319 introduced a schema definition for
Form
. In principle, this new definition was added to let typescript users have a type for a generic form. Sadly, json-schema-to-typescript does not automatically do it but you have to enable it. This PR enables the generation of unreachable definitions. As you can see on the diff enabling such option causes also the generation of a long list of unwanted comments. I tried to get rid of them without any success. I'm waiting for an answer from the main contributors to remove them, meanwhile, I think we can live with them.