Update codec match algorithm to be more general (work with AV1) #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henbos
commented
Mar 27, 2025
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 27, 2025
Test adds test coverage for the following spec PR: w3c/webrtc-pc#3043 WPT test coverage is necessary before merging the PR. We initially expect to fail (setParameters throwing on not ignoring profile) because of chromium:406545149. Bug: chromium:406545149 Change-Id: I7b85f0c9f3cbe959303b2543a450fc82fc831d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400755 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1438652}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 27, 2025
Test adds test coverage for the following spec PR: w3c/webrtc-pc#3043 WPT test coverage is necessary before merging the PR. We initially expect to fail (setParameters throwing on not ignoring profile) because of chromium:406545149. Bug: chromium:406545149 Change-Id: I7b85f0c9f3cbe959303b2543a450fc82fc831d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400755 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1438652}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 27, 2025
Test adds test coverage for the following spec PR: w3c/webrtc-pc#3043 WPT test coverage is necessary before merging the PR. We initially expect to fail (setParameters throwing on not ignoring profile) because of chromium:406545149. Bug: chromium:406545149 Change-Id: I7b85f0c9f3cbe959303b2543a450fc82fc831d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400755 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1438652}
jan-ivar
approved these changes
Mar 27, 2025
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 29, 2025
…ry match of AV1 profile., a=testonly Automatic update from web-platform-tests Add WPT test coverage for codec dictionary match of AV1 profile. Test adds test coverage for the following spec PR: w3c/webrtc-pc#3043 WPT test coverage is necessary before merging the PR. We initially expect to fail (setParameters throwing on not ignoring profile) because of chromium:406545149. Bug: chromium:406545149 Change-Id: I7b85f0c9f3cbe959303b2543a450fc82fc831d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400755 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1438652} -- wpt-commits: e78767e04f623d9f85a646fa7825a9e715a76176 wpt-pr: 51637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3037
Preview | Diff