Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve amendment management #2995

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Improve amendment management #2995

merged 14 commits into from
Sep 12, 2024

Conversation

dontcallmedom
Copy link
Member

@dontcallmedom dontcallmedom commented Sep 2, 2024

This offers a significantly improved infrastructure to manage the amendments to the WebRTC Recommendation.

In particular:

  • the diff that are displayed for amended sections are now granular, rather than the block-by-block diff used in the previous system
  • errors in marking up amendments now make use of the ReSpec error mechanism, which should make it easier to identify them, including in the CI system
  • the markup needed to indicate a complete new section is much simpler (no longer needed to add in base-rec.html, and only need to reference the specific section being added) - this follows from discussion with @Orphis in a recent instance

In addition, this fixes a number of amendments that had not been properly classified.

speced/respec#4786 will be needed to ensure the resulting generated markup is valid.


Preview | Diff

@dontcallmedom dontcallmedom marked this pull request as ready for review September 11, 2024 09:10
needed to make markup output valid
@dontcallmedom
Copy link
Member Author

this is now ready to be merged and would benefit from being merged rapidly since it impacts other pull requests documenting amendments (e.g. #2988) cc @jan-ivar @alvestrand

@alvestrand alvestrand merged commit 39897d1 into main Sep 12, 2024
3 checks passed
dontcallmedom added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants