Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTCPeerConnection.createDTMFSender and add RTCRtpSender.dtmf. #167

Closed
wants to merge 1 commit into from

Conversation

pthatcherg
Copy link
Contributor

Fixing #132

@alvestrand
Copy link
Contributor

Needs to be integrated to main after #175, since it references RTCRTPSender.

@fluffy
Copy link
Contributor

fluffy commented Jan 15, 2015

Need to think about how this interacts with SDP - Will all tracks have DTMF negotiated for them ? seems like a waste of PT when it is usually not needed.

@pthatcherg
Copy link
Contributor Author

Cullen: Would it make sense to have an option in RTCOfferAnwerOptions.dtmf just as we have RTCOfferAnswerOptions.voiceActivityDetection in pthatcherg@90af82e?

If that would work, I can propose it on the list.

@pthatcherg
Copy link
Contributor Author

In Chrome at least, we always put DTMF in the offer, so we're already using
the PT. Meanwhile, we're always negotiating PCMA and PCMU. In other
words, we're already using lots of PTs. Meanwhile, is it even possible to
re-negotiate with DTMF later if the DTMF isn't in the original offer? In
that case, we have to have it in the original offer anyway.

On Thu, Jan 15, 2015 at 7:54 AM, Cullen Jennings [email protected]
wrote:

Need to think about how this interacts with SDP - Will all tracks have
DTMF negotiated for them ? seems like a waste of PT when it is usually not
needed.


Reply to this email directly or view it on GitHub
#167 (comment).

@fluffy
Copy link
Contributor

fluffy commented Feb 19, 2015

OK - seems reasonable to me

@alvestrand alvestrand assigned adam-be and unassigned fluffy Feb 26, 2015
@adam-be
Copy link
Member

adam-be commented Mar 10, 2015

Rebased and integrated.

@adam-be adam-be closed this Mar 10, 2015
@jesup
Copy link

jesup commented Mar 10, 2015

I"ll note that Firefox has not thus far added DTMF to our offers (nor have we integrated support for it yet). If we're requiring DTMF on all audio channels, that's new - IMHO it should be in OfferAnswerOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants