Skip to content

Remove crash-reporting #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove crash-reporting #49

wants to merge 1 commit into from

Conversation

stephenmcgruer
Copy link

The only IDL in this was marked 'exclude' in WICG/crash-reporting#8

The only IDL in this was marked 'exclude' in
WICG/crash-reporting#8
@stephenmcgruer
Copy link
Author

(I have no idea if this is correct, but hopefully @foolip can tell me if/where I've made mistakes. I just searched for crash-reporting and deleted the bits that looked like they shouldn't be here).

@foolip
Copy link
Member

foolip commented Jul 16, 2020

You ought only need to remove the IDL files, and possibly only the one in ed/. To figure out which, you'd have to find out what files reffy would still create when run, which you do, well, by running it...

Maybe @tidoust has a more satisfactory answer for how to manage this :)

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments:

  1. See Do not export CrashReportBody to reffy WICG/crash-reporting#8 (comment). As things stand, Reffy will continue to extract and produce the IDL extracts, and thus will re-create the file on next run if we delete it.
  2. I do not see any reason to delete the files under ed/dfns and tr/dfns. These document the definitions in the spec, which shouldn't cause any problem. If we don't want the definitions to appear, that probably means we do not want the spec to be parsed at all, in which case the spec should rather be dropped from w3c/browser-specs.

@tidoust
Copy link
Member

tidoust commented Mar 11, 2021

I'm closing down this PR without merging. The discussion on WICG/reporting seems to have stalled for now. Dropping the files in webref will not be the right solution in any case. If something is needed on the extraction side, it will be an update in Reffy's crawling logic.

@tidoust tidoust closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants