Skip to content

fix(tokeniser): prevent any use of toString #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saschanaz merged 1 commit into from
Aug 30, 2019
Merged

fix(tokeniser): prevent any use of toString #399

saschanaz merged 1 commit into from
Aug 30, 2019

Conversation

@saschanaz
Copy link
Member

@saschanaz saschanaz commented Aug 30, 2019

Closes #230.

I think throwing early on tokenising phase is easiest and best.

This patch includes:

  • A relevant test

@saschanaz saschanaz merged commit 8cff982 into gh-pages Aug 30, 2019
@saschanaz saschanaz deleted the no-tostring branch August 30, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reserved identifiers must be prevented

3 participants

@saschanaz @marcoscaceres