Skip to content

feat: require dictionary arguments not to be nullable #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saschanaz merged 5 commits into from
Jul 13, 2019
Merged

feat: require dictionary arguments not to be nullable #360

saschanaz merged 5 commits into from
Jul 13, 2019

Conversation

@saschanaz
Copy link
Member

@saschanaz saschanaz commented Jul 13, 2019

On top of #359

marcoscaceres
marcoscaceres approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good too.

@saschanaz saschanaz merged commit e5b8747 into gh-pages Jul 13, 2019
@saschanaz saschanaz deleted the nullable-dict branch July 13, 2019 05:28
@saschanaz saschanaz changed the title feat: require dictionary arguments not to be nullable feat: require dictionary arguments not to be nullable Jul 13, 2019
@marcoscaceres
Copy link
Member

marcoscaceres commented Jul 13, 2019

👍👍👍Will wait for this to be published before releasing ReSpec.

@saschanaz
Copy link
Member Author

saschanaz commented Jul 13, 2019

Did it 🎉 : 72c6db0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschanaz @marcoscaceres