Add trivia for enums and typedefs #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Jun 14, 2018
Member
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
Couple of nits, but looking good.
lib/webidl2.js
Outdated
| trivia | ||
| }; | ||
| consume("{") || error("No curly for enum"); | ||
| const open = consume("{") || error("No curly for enum"); |
Member
There was a problem hiding this comment.
“Curly” might be confusing. Maybe “no opening {...”
| let value_expected = true; | ||
| while (true) { | ||
| if (consume("}")) { | ||
| const close = consume("}"); |
Member
There was a problem hiding this comment.
Had expected to see “No closing } for enum” somewhere as an error. Is that possible?
Member
Author
There was a problem hiding this comment.
Currently enum X { throws with Unexpected value in enum, which is weird here. I introduced eof type in #185, maybe we can do better with it by Unexpected end of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
triviafield for enum values.