Use eslint #196
Use eslint #196
Conversation
| "mocha": true | ||
| }, | ||
| "extends": "eslint:recommended", | ||
| "rules": { |
There was a problem hiding this comment.
Given that we are extending “eslint:recommended”, it possible to only list the ones we are changing?
There was a problem hiding this comment.
I think the generated one is more strict, as eslint --init reads our existing code to get an optimized configuration. For example, array-callback-return is not enabled by default in eslint:recommended.
There was a problem hiding this comment.
We may still review those off things, though.
There was a problem hiding this comment.
So it seems we can just remove those off lines, but IMO maybe those lines are helpful for future reconsideration (at least we know they exist!). Should they be removed?
There was a problem hiding this comment.
I don’t mind keeping it as is, but I’m worried that we don’t know which are set by us or why - and the recommended set can change or have new things added. I guess it’s not a big deal as the code base is only small.
There was a problem hiding this comment.
I’m worried that we don’t know which are set by us or why
We have rules list and their detailed descriptions and examples, so maybe we can further modify the configuration if we meet some problems.
I'm hesitating to just remove them, as some actually are helpful... 636947f
|
Replaced by #202 |
Config file generated by
npx eslint --init.Closes #167