Conversation
marcoscaceres
approved these changes
Feb 5, 2018
Member
|
Worth doing a release or should we sit on this for a bit? |
Member
Author
|
This doesn't boost performance or add any features, so we should sit on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keywords can be used as property names in ES5 so this PR removes quotes for them.
Originally I intended to use
array.join()for string concatenation in writer.js and then found that it's actually slower on V8. Hmm.function iterate(things) { if (!things) return; - let ret = ""; - for (const thing of things) ret += dispatch(thing); - return ret; + return things.map(dispatch).join(''); };