Add getKeys() proposal #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanguokai
reviewed
Jun 28, 2024
xeenon
reviewed
Jun 29, 2024
xeenon
reviewed
Jun 29, 2024
oliverdunk
commented
Jun 29, 2024
There was a problem hiding this comment.
Thanks for doing a pass @xeenon, added some replies to your comments.
Rob--W
approved these changes
Jun 30, 2024
xeenon
approved these changes
Jun 30, 2024
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jul 4, 2024
SHA: ef9750b Reason: push, by oliverdunk Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 4, 2024
SHA: ef9750b Reason: push, by oliverdunk Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
||
| There is developer interest for this API in | ||
| [#601](https://github.com/w3c/webextensions/issues/601). While we don't expect | ||
| significant immediate usage, it is a small, well-scoped API and should not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for the getKeys() method from #601, originally proposed by @polywock.
I am planning to implement this in Chromium as part of some work on the
browser.storageAPI.