Add back the conservative page loading strategy#1000
Open
shs96c wants to merge 1 commit into
Open
Conversation
This waits for all resources of a page to have finished loading, and not just for the readyState to reach "complete". Addresses w3c#893.
Contributor
Author
|
Marking as an L2 fix. It's deemed to be a new feature, which is not in keeping with the CR period. |
Member
|
Per the testing policy, this PR can't be accepted without a corresponding test in the web-platform-tests reposiotry. |
Member
|
@shs96c Do you have time to also write the tests for this? Because we don’t currently have any tests for the other page loading strategies it may be required to do those first, which could be a bit of work. @whimboo has written some excellent Marionette navigation tests that we would be happy to share with WPT, but we need to CC-0 license it first. @whimboo, would that be easy to do? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This waits for all resources of a page to have finished
loading, and not just for the readyState to reach
"complete".
Addresses #893.
This change is