-
Notifications
You must be signed in to change notification settings - Fork 60
emulation.setUserAgentOverride
#947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e22449c to
989153d
Compare
8cb52cd to
cb5185a
Compare
9d80a52 to
7c20e1a
Compare
|
@OrKoN @juliandescottes please take a look |
7c20e1a to
b024ff2
Compare
|
@juliandescottes please take a look |
|
@juliandescottes @whimboo PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sadym-chromium ! Overall that looks fine to me. Just some nits and suggestions. Before approving I just want to check the reason why we attach this to the session rather than to the remote end. Back to you
b9c9a42 to
017d873
Compare
|
@juliandescottes PTAL I believe I addressed your comments, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't notice that the context/contexts error was also in the other commands. Thanks for fixing them as well. Looks good to me now!
4737cc2 to
4e6ff98
Compare
4e6ff98 to
40c6c16
Compare
Specification for
emulation.setUserAgentOverridecommand.User-Agentheaders is set BEFORE the "WebDriver BiDi before request sent" is invoked, so there is no way to distinguish between the user explicitly set theUser-Agentvs the defaultUser-Agentvalue was used. Use the hook in Fetch spec: [WebDriver BiDi] emulateuser-agentstring whatwg/fetch#1851User-Agentas the result of thenavigator.userAgent. Use the hook in HTML spec: [WebDriver BiDi] emulateuser-agentstring whatwg/html#11576Preview | Diff