-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixup algs contd 2 #495
Merged
Merged
fixup algs contd 2 #495
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3dc51c5
explicitly level 1, fixes #475
763f44c
improve allowCredentials and transports handling in #getAssertion, fi…
c3c9ac8
added ... identified by rpId for clarification
rlin1 9ff5bbf
grammar fixup
14010fa
add back ' = []' on excludeCredentials, fixes #268
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<h1>Web Authentication:<br>An API for accessing Public Key Credentials<br>[Level 1]</h1> | ||
<pre class='metadata'> | ||
Title: Web Authentication: An API for accessing Public Key Credentials | ||
Status: ED | ||
Prepare for TR: true | ||
TR: https://www.w3.org/TR/webauthn/ | ||
|
@@ -11,7 +11,7 @@ Previous Version: https://www.w3.org/TR/2016/WD-webauthn-20160928/ | |
Previous Version: https://www.w3.org/TR/2016/WD-webauthn-20160902/ | ||
Previous Version: https://www.w3.org/TR/2016/WD-webauthn-20160531/ | ||
Shortname: webauthn | ||
Level: | ||
Level: 1 | ||
Editor: Vijay Bharadwaj, w3cid 55440, Microsoft, [email protected] | ||
Editor: Hubert Le Van Gong, w3cid 84817, PayPal, [email protected] | ||
Editor: Dirk Balfanz, w3cid 47648, Google, [email protected] | ||
|
@@ -621,7 +621,7 @@ When this method is invoked, the user agent MUST execute the following algorithm | |
1. Let |clientDataHash| be the [=hash of the serialized client data=] represented by |clientDataJSON|. | ||
|
||
1. Let |currentlyAvailableAuthenticators| be a new [=ordered set=] consisting of all [=authenticators=] | ||
available on this platform. | ||
currently available on this platform. | ||
|
||
1. Let |selectedAuthenticators| be a new [=ordered set=]. | ||
|
||
|
@@ -828,20 +828,39 @@ When this method is invoked, the user agent MUST execute the following algorithm | |
1. If |allowCredentialDescriptorList| | ||
<dl class="switch"> | ||
: [=list/is not empty=] | ||
:: [=in parallel=], [=list/for each=] credential descriptor |C| in |allowCredentialDescriptorList|: | ||
1. If <code>|C|.{{transports}}</code> [=list/is not empty=], the client SHOULD select one |transport| from | ||
{{transports}}. Then, using |transport|, invoke the [=authenticatorGetAssertion=] operation on | ||
|authenticator|, with |rpId|, |clientDataHash|, |allowCredentialDescriptorList|, and | ||
|authenticatorExtensions| as parameters. | ||
|
||
1. Otherwise, using local configuration knowledge of the appropriate transport to use with |authenticator|, | ||
invoke the [=authenticatorGetAssertion=] operation on |authenticator| with |rpId|, | ||
|clientDataHash|, |allowCredentialDescriptorList|, and |clientExtensions| as parameters. | ||
:: 1. Let |distinctTransports| be a new [=ordered set=]. | ||
|
||
1. [=list/For each=] credential descriptor |C| in |allowCredentialDescriptorList|, | ||
[=set/append=] each value, if any, of <code>|C|.{{transports}}</code> to |distinctTransports|. | ||
|
||
Note: This will aggregate only distinct values of {{transports}} (for this [=authenticator=]) in | ||
|distinctTransports| due to the properties of [=ordered sets=]. | ||
|
||
1. If |distinctTransports| | ||
<dl class="switch"> | ||
: [=list/is not empty=] | ||
:: The client selects one |transport| value from |distinctTransports|, possibly incorporating local | ||
configuration knowledge of the appropriate transport to use with |authenticator| in making its | ||
selection. | ||
|
||
Then, using |transport|, invoke [=in parallel=] the [=authenticatorGetAssertion=] operation on | ||
|authenticator|, with |rpId|, |clientDataHash|, |allowCredentialDescriptorList|, and | ||
|authenticatorExtensions| as parameters. | ||
|
||
: [=list/is empty=] | ||
:: Using local configuration knowledge of the appropriate transport to use with |authenticator|, | ||
invoke [=in parallel=] the [=authenticatorGetAssertion=] operation on |authenticator| with |rpId|, | ||
|clientDataHash|, |allowCredentialDescriptorList|, and |clientExtensions| as parameters. | ||
</dl> | ||
|
||
: [=list/is empty=] | ||
:: Using local configuration knowledge of the appropriate transport to use with |authenticator|, invoke | ||
[=in parallel=] the [=authenticatorGetAssertion=] operation on |authenticator| with |rpId|, |clientDataHash|, | ||
and |clientExtensions| as parameters. | ||
|
||
Note: In this case, the [=[RP]=] did not supply a list of acceptable credential descriptors. Thus the | ||
authenticator is being asked to exercise any credential it may possess that is bound to | ||
the [=[RP]=] identified by |rpId|. | ||
</dl> | ||
|
||
1. [=set/Append=] |authenticator| to |issuedRequests|. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/identified/as identified/