Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revamped [[Create]]() method lacks origin argument #661

Closed
equalsJeffH opened this issue Oct 25, 2017 · 0 comments · Fixed by #665
Closed

revamped [[Create]]() method lacks origin argument #661

equalsJeffH opened this issue Oct 25, 2017 · 0 comments · Fixed by #665
Assignees
@equalsJeffH
Labels
stat:pr-open subtype:algorithms/WebIDL type:technical
Milestone
WD-07

Comments

@equalsJeffH
Copy link
Contributor

equalsJeffH commented Oct 25, 2017 •
edited
Loading

when doing PR #498 I neglected to add the origin arg to webauthn's [Create] method.

See update to credman queued in my PR w3c/webappsec-credential-management#100
@equalsJeffH equalsJeffH added this to the WD-07 milestone Oct 25, 2017
@equalsJeffH equalsJeffH self-assigned this Oct 25, 2017
equalsJeffH pushed a commit that referenced this issue Oct 27, 2017
actually improve #254, and fix #661
7a7f5d7
@equalsJeffH equalsJeffH mentioned this issue Oct 30, 2017
Merged
equalsJeffH added a commit that referenced this issue Nov 9, 2017
@equalsJeffH
fix #254: credman alignment: update #getAssertion section a la PR #498 (
d468a75 
#665)

* actually improve #254, and fix #661

* DiscoFrmExtSource(options) -> (origin, options)

* make [[DiscoFrmExtSource]]'s exposition match [[Create]]'s

* deal with yet another fix #254 straggler in [[Create]]

* get rid of |global| in [[DiscoFrmExtSource]]

* remove 'in parallel' and 'global' stuff from #discover-from-external-source alg

* work on #discover-from-external-source alg to improve #254

* finish (one hopes) work on #discover-from-external-source alg to fix #254

* minor editorial

* repair #createCredential intro parag, improves issue #671

* complete fix #671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@equalsJeffH equalsJeffH

Labels
stat:pr-open subtype:algorithms/WebIDL type:technical
Projects
None yet
Milestone
WD-07
Development

Successfully merging a pull request may close this issue.

fix #254: credman alignment: update #getAssertion section a la PR #498 w3c/webauthn
1 participant
@equalsJeffH