Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send reports for Permissions Policy violations in iframe to parent frame's endpoint #546

Merged
merged 15 commits into from
Sep 25, 2024
Merged

Send reports for Permissions Policy violations in iframe to parent frame's endpoint #546

merged 15 commits into from
Sep 25, 2024

Conversation

shhnjk
Copy link
Member

@shhnjk shhnjk commented Apr 30, 2024 •
edited by pr-preview bot
Loading

This change implements permission policy reporting for potential Permissions Policy violations to parent frames.

Currently, Permissions Policy violations inside an iframe is not sent to parent frame, because of security concerns. However, this makes it difficult for websites to roll out Permissions Policy because the site owner does not have insight into permission breakage in iframes.

The change is implemented in a way that it does not leak any new information to parent frame, while sending signals that iframes might be affected by the Permissions Policy.

Fixes: #537

Preview | Diff

@shhnjk shhnjk requested a review from clelland April 30, 2024 23:12
@shhnjk
Copy link
Member Author

shhnjk commented May 11, 2024

Friendly ping @clelland :)

@shhnjk
Copy link
Member Author

shhnjk commented Aug 6, 2024

@clelland, I've introduced Generate report for potential violation of permissions policy on settings. PTAL!

clelland
clelland reviewed Aug 14, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
clelland
clelland reviewed Aug 14, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@shhnjk
Copy link
Member Author

shhnjk commented Aug 20, 2024

@clelland, PTAL when you have time!

clelland
clelland reviewed Sep 6, 2024
View reviewed changes
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@shhnjk
Update index.bs
9df72a4 
Add a monkey patch
clelland
clelland reviewed Sep 21, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@clelland
Copy link
Collaborator

This is looking really good, @shhnjk - other than one nit, I think it's probably good to merge

@shhnjk
Copy link
Member Author

shhnjk commented Sep 23, 2024

@clelland feel free to merge this :)

@clelland clelland merged commit 314ffc9 into w3c:main Sep 25, 2024
2 checks passed
@clelland
Copy link
Collaborator

Thanks, @shhnjk ! This looks good now.

github-actions bot added a commit that referenced this pull request Sep 25, 2024
@shhnjk @github-actions
Send reports for Permissions Policy violations in iframe to parent fr…
59107ff 
…ame's endpoint (#546)

SHA: 314ffc9
Reason: push, by clelland

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clelland clelland clelland left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send reports for Permissions Policy violations in iframe to parent frame's endpoint
2 participants
@shhnjk @clelland