Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyboard to remove normative acceptance of "completely custom … #3670

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

detlevhfischer
Copy link
Contributor

@detlevhfischer detlevhfischer commented Feb 2, 2024

Changes

"deviating from these conventions does not fail the normative requirement"

to

"deviating from these conventions does not always fail the normative requirement"

Removes

"(or even a completely custom key or key combination)"

...since this is likely to fail AT users relying on the keyboard interface.

patrickhlauke and others added 20 commits February 14, 2021 23:16
make clear that ANY key would pass
replacing "keyboard users" with "users of the keyboard interface" in two places to emphasize that the SC also addresses the needs of AT users that rely on the keyboard interface - and that by implication any custom key input would not serve their needs.

Removing the phrase referring to custom key operation.
…ow reintroduce the "custom key combination" idea

Also harmonises some suggestions/changes that were done in only one of the two matching notes
…key or key combinations"

Changes 
> "deviating from these conventions does <em>not</em> fail the normative requirement" 

to 
> deviating from these conventions does <em>not</em> always fail the normative requirement
@patrickhlauke
Copy link
Member

saying "does not always fail" without explicitly explaining when it does or doesn't ... won't really help authors or testers in determining whether they do pass or fail

@@ -75,19 +75,18 @@ <h2>Intent of Keyboard</h2>
the platform/user agent conventions it may be difficult to use, as users will need
to learn different interaction methods. As a <em>best practice</em>, content
should follow the platform/user agent conventions. However, deviating from these
conventions does <em>not</em> fail the normative requirement of this Success Criterion.</p>
conventions does <em>not</em> always fail the normative requirement of this Success Criterion.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially dealing with @patrickhlauke's feedback...

Suggested change
conventions does <em>not</em> always fail the normative requirement of this Success Criterion.</p>
conventions does <em>not</em> automatically fail the normative requirement of this Success Criterion.</p>

(The rest of his comment is addressed, IMHO, by the text that follows).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that still leaves doubt though about when it does or doesn't, so authors and testers still are none the wiser

Base automatically changed from patrickhlauke-understanding-keyboard-note to main February 14, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants