Export the two CSP directives #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@robbiemc I think this should be enough for your requirements? Apologies for the delay in addressing this. |
fred-wang
approved these changes
Oct 24, 2024
Collaborator
fred-wang
left a comment
fred-wang
left a comment
There was a problem hiding this comment.
Not super familiar with bikeshed, but that looks correct per https://speced.github.io/bikeshed/#dfn-export
It seems @robbiemc already merged WICG/isolated-web-apps#43 with a <pre class="anchors"> tweak, but this may still be useful anyway.
github-actions bot
added a commit
that referenced
this pull request
Oct 28, 2024
SHA: e5717b9 Reason: push, by koto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robbiemc
added a commit
to robbiemc/isolated-web-apps
that referenced
this pull request
Oct 28, 2024
w3c/trusted-types#545 exports the require-trusted-types-for-directive definition so the manually defined anchor section isn't needed anymore.
|
Sorry, I missed your original question about this! This does indeed make it linkable, and I sent WICG/isolated-web-apps#55 to remove the anchor definition now that the link works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #538
Preview | Diff