Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrate in diagram that timestamps are not necessarily consecutive #323

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Apr 10, 2022

Closes #164

@yoavweiss
Copy link
Contributor

Thanks!
I'm not sure "stall" is the best word to describe the delays that can be incurred from the browser exceeding the DNS, TCP/QUIC connection and in-slight request limits. Maybe a "potential delay" bubble below, with arrows pointing to before the DNS, TCP/QUIC and request squares?

@noamr
Copy link
Contributor Author

noamr commented Apr 11, 2022

Thanks! I'm not sure "stall" is the best word to describe the delays that can be incurred from the browser exceeding the DNS, TCP/QUIC connection and in-slight request limits. Maybe a "potential delay" bubble below, with arrows pointing to before the DNS, TCP/QUIC and request squares?

What's the word used for this in DevTools? I want to use the same vocabulary

@yoavweiss
Copy link
Contributor

Chrome DevTools indeed uses the word "stalled" for the connection parts, but doesn't talk about other types of delays. IMO, it's inaccurate, but there's no point in bikeshedding the diagram, as it's easy to change it in the future if complaints come in.

What about changing it to a single bubble pointing it at the 3 potential locations?

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks great :)

@noamr noamr merged commit 148c98c into gh-pages Apr 13, 2022
@noamr noamr deleted the diagrams branch April 13, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elaborate on stalled or blocked stage in specs
2 participants