Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about "stalled" or "blocked" time #169

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

jasonslyvia
Copy link

@jasonslyvia jasonslyvia commented Oct 10, 2018

Fixes #164


Preview | Diff

@@ -947,6 +947,12 @@ <h3>Processing Model</h3>
<!-- Source: https://docs.google.com/document/d/1I7XGNJ57Qgjkg9pL11s7MK7zGEcwAgdNj1W5f7NKbW8/ -->
<img src="timestamp-diagram.svg" alt="Resource Timing attributes"
style='margin-top: 1em'></figure>
<aside class="note">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "The phases illustrated above are not necessarily consecutive, and user agents may spend time between them on processing, waiting for TCP connections to become available, waiting before sending requests to prevent contention or any other implementation detail. The unaccounted time spent by the user agent can be calculated as the difference between the consecutive timestamps. Its sum can be calculated as the difference between the duration value and responseEnd - startTime. "

@nicjansma @igrigorik - thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, tbh I find this really cryptic and hard to grok. As in, you have to be well versed in the nuance here to understand what this is saying. If our concern is specifically "stalled" / "blocked", I'd focus and lead with that.

"The user agent may inject other processing steps that are not included in the above diagram. For example, due to limitations of HTTP/1.x TCP connection limits, the user agent may be blocked waiting for an available socket, and such delays are not explicitly exposed by this specification."

~ish?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the fact that many developers collect performance metrics based on this diagram, personally I prefer @yoavweiss 's version since it presents a clear formula for calculating "stalled" time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants