Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPV-defined concepts (e.g. dpv:Concept) have missing rdfs:isDefinedBy #81

Closed
pmcb55 opened this issue Nov 22, 2022 · 3 comments
Closed

DPV-defined concepts (e.g. dpv:Concept) have missing rdfs:isDefinedBy #81

pmcb55 opened this issue Nov 22, 2022 · 3 comments
Assignees
@coolharsh55

Comments

@pmcb55
Copy link

pmcb55 commented Nov 22, 2022

Hi,

I'm writing some basic Best Practice-checking code, and in the process I noticed that there are just 6 terms (from the 631 terms in DPV) that are missing rdfs:isDefinedBy triples, namely:

  • dpv:Concept
  • dpv:isSubTypeOf
  • dpv:isInstanceOf
  • dpv:Relation
  • dpv:hasRange

I guess this is just an oversight, so is it worth checked and rectifying...?
@coolharsh55
Copy link
Collaborator

coolharsh55 commented Nov 23, 2022 •
edited
Loading

Hi. Not an oversight, but an intentional decision because we hadn't agreed on a formal definition for these terms and their use to create SKOS and OWL terms.

With the OWL related issues resolved, these concepts will also get their own definitions and metadata in the coming commits. Right now they just have a label.

@pmcb55
Copy link
Author

pmcb55 commented Nov 23, 2022

Ah! Ok, good to know Harsh - I'll just close this issue now so (since you were already fully aware of this).
Cheers.

@pmcb55 pmcb55 closed this as completed Nov 23, 2022
@coolharsh55 coolharsh55 reopened this Nov 23, 2022
@coolharsh55
Copy link
Collaborator

Hi. Thanks anyways Pat. I've re-opened it, so that the appropriate commit will close this automatically. Just in case implementing it gets delayed for some reason.

@coolharsh55 coolharsh55 changed the title DPV vocab is missing the rdfs:isDefinedBy triple for just 6 (of 631) vocab terms DPV-defined concepts (e.g. dpv:Concept) have missing rdfs:isDefinedBy Nov 23, 2022
@coolharsh55 coolharsh55 self-assigned this Nov 23, 2022
coolharsh55 added a commit that referenced this issue Nov 24, 2022
@coolharsh55
fixes typos in IRIs, resolves #81; updates terms
cdeffda 
The following typos in IRIs were fixed using the new SHACL shapes from
previous commit:
- dpv:expiry relation instead of dpv:hasExpiry relation in consent
- dpv:hasConsequenceOn was used as a parent even though it was proposed.
  The term has been promoted to accepted status
- Typos in Technical measures where Crypto- was mistyped as Cryto-

Errors in labels:
- MaintainCreditCheckingDatabase
- MaintainCreditRatingDatabase

The following terms were updated:
- GDPR's legal bases where text has been added from Art.6 and the parent
  terms have been aligned with main spec's legal bases (including
  creation of new terms to match granularity)
- Anonymisation and Pseudonymisation have been changed to be types of
  Deidentification techniques (as the grouping parent concept) to
  distinguish them following discussions in #15
- DPV-LEGAL has laws and DPAs for USA from contributions by @JonathanBowker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coolharsh55 coolharsh55

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmcb55 @coolharsh55