Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add that AXRoleDescription and AXCustomContent value are localizable strings #20

Merged
merged 7 commits into from
Jan 19, 2023

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Jan 6, 2023

Adds the modified version of the note from core-aam specification described in #18 (comment)

Also adds a space after the "AXCustomContent" label in the tables.

Fixes #18


Preview | Diff

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a new normative section matching Translatable Attributes in the ARIA and HTML Specs.

https://w3c.github.io/aria/#translatable-attributes

Editorial Nit: I would keep this PR for the white space changes, roll back the note, and file a new issue for the new section.

@mattgarrish mattgarrish changed the title Add note that AXRoleDescription and AXCustomContent value are localizable strings Add that AXRoleDescription and AXCustomContent value are localizable strings Jan 8, 2023
@mattgarrish
Copy link
Member Author

Thanks, @cookiecrook, I'll try to look into your suggestion this week.

I've incorporated the whitespace fix into the main branch as it's not significant to the text and merged the update back into this branch so I can keep it for the eventual fix. This way we can keep the discussion intact.

@mattgarrish mattgarrish marked this pull request as draft January 10, 2023 17:59
@mattgarrish mattgarrish marked this pull request as ready for review January 13, 2023 15:31
@mattgarrish
Copy link
Member Author

Let me know if this is better @cookiecrook.

I tried my best to adapt the section you pointed to, but not sure if I've got the right mix of translatable attributes with this being translatable mapping strings.

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks. I now further understand the awkwardness of trying to take a spec "translatable attributes" section and squeeze it into an AAM. Sorry I didn't think that far ahead when I made the prior comment, but I think you've done a good job reinterpreting as necessary.

@mattgarrish mattgarrish merged commit a057778 into main Jan 19, 2023
@mattgarrish mattgarrish deleted the fix/issue-18 branch January 19, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AXCustomContent localizable strings
2 participants