Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check feature dispositions #265

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Oct 9, 2024

Closes #264 by adding missing feature dispositions. Also adds term definition links to each TTML2 feature.


Preview | Diff

@nigelmegitt
Copy link
Contributor Author

I noticed that the default Respec behaviour is to use the TTML2 1st Ed Rec, but we are referencing TTML2 features that are only introduced in 2nd Edition, so I updated the pull request to reference the most recent TTML2 CR Snapshot - unfortunately even though SpecRef knows that this is the most recent version of ttml2 it doesn't reference it. The alternative is to be explicit and point to [ttml2-20210309] but that's quite long winded, so instead I added a local bibliography reference.

Happy to revert it if we know a better way to alias [TTML2] to the latest 2nd Ed version.

@nigelmegitt nigelmegitt force-pushed the issue-0264-check-feature-dispositions branch from 97a13a2 to dbb8b4f Compare October 17, 2024 16:10
@nigelmegitt nigelmegitt added the agenda Issue flagged for in-meeting discussion label Nov 5, 2024
@andreastai
Copy link

To be consistent it should say for #profile-root: "This is the profile expression of the prohibition of 5.6.3 ttp:profile."

@nigelmegitt
Copy link
Contributor Author

To be consistent it should say for #profile-root: "This is the profile expression of the prohibition of 5.6.3 ttp:profile."

@andreastai Done (slightly differently) in 2bf8b2c:

This is the profile expression of the prohibition of the ttp:profile attribute on the <tt> element as specified in 5.6.3 ttp:profile.

@css-meeting-bot
Copy link
Member

The Timed Text Working Group just discussed Check feature dispositions w3c/dapt#265, and agreed to the following:

  • SUMMARY: Awaiting approval review
The full IRC log of that discussion <nigel> Subtopic: Check feature dispositions #265
<nigel> github: https://github.com//pull/265
<cpn> Nigel: This was in response to an issue from Andreas. I think I fixed the inconsistency
<cpn> Andreas: I had a brief look, but haven't given feedback or approval yet
<cpn> Nigel: It's a substantive change, it would need checking. Would someone like to volunteer to do that?
<cpn> ... I'm not comfortable merging it directly, because of the potential impacts
<cpn> ... We need to check the profile documents and the dispositions match correctly
<cpn> Andreas: I can do it but not in the next days
<nigel> SUMMARY: Awaiting approval review

@nigelmegitt nigelmegitt force-pushed the issue-0264-check-feature-dispositions branch from 2bf8b2c to 8350bcd Compare November 13, 2024 15:18
Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • feature #contentProfiles is required in dapt processor profiles but it is optional in the dispositions
  • extension represents is required in the dapt content profile but it is "only" permitted in the dispositions

Thanks @nigelmegitt

Otherwise the changes look good to me.

@nigelmegitt
Copy link
Contributor Author

Thanks @andreastai , good catches! Fixed in 7dc454b.

Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixes in 7dc454b look good to me.

@nigelmegitt nigelmegitt merged commit 7c4d4bc into main Nov 21, 2024
2 checks passed
@nigelmegitt nigelmegitt deleted the issue-0264-check-feature-dispositions branch November 21, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agenda Issue flagged for in-meeting discussion editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align section F.1 (Disposition of features) with section F.2 (DAPT Content profile)
3 participants