-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check feature dispositions #265
Conversation
I noticed that the default Respec behaviour is to use the TTML2 1st Ed Rec, but we are referencing TTML2 features that are only introduced in 2nd Edition, so I updated the pull request to reference the most recent TTML2 CR Snapshot - unfortunately even though SpecRef knows that this is the most recent version of Happy to revert it if we know a better way to alias |
97a13a2
to
dbb8b4f
Compare
To be consistent it should say for #profile-root: "This is the profile expression of the prohibition of 5.6.3 ttp:profile." |
@andreastai Done (slightly differently) in 2bf8b2c:
|
The Timed Text Working Group just discussed
The full IRC log of that discussion<nigel> Subtopic: Check feature dispositions #265<nigel> github: https://github.com//pull/265 <cpn> Nigel: This was in response to an issue from Andreas. I think I fixed the inconsistency <cpn> Andreas: I had a brief look, but haven't given feedback or approval yet <cpn> Nigel: It's a substantive change, it would need checking. Would someone like to volunteer to do that? <cpn> ... I'm not comfortable merging it directly, because of the potential impacts <cpn> ... We need to check the profile documents and the dispositions match correctly <cpn> Andreas: I can do it but not in the next days <nigel> SUMMARY: Awaiting approval review |
2bf8b2c
to
8350bcd
Compare
Also refactor how the row headers are styled, because I found them too hard to spot.
8350bcd
to
0445540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- feature
#contentProfiles
is required in dapt processor profiles but it is optional in the dispositions - extension
represents
is required in the dapt content profile but it is "only" permitted in the dispositions
Thanks @nigelmegitt
Otherwise the changes look good to me.
Addresses @andreastai review feedback
Thanks @andreastai , good catches! Fixed in 7dc454b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixes in 7dc454b look good to me.
Closes #264 by adding missing feature dispositions. Also adds term definition links to each TTML2 feature.
Preview | Diff