Add Script Event type constraints #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor lists of SHOULD/SHOULD NOT/MAY constraints into unordered lists * Add that Pre-Recording Scripts SHOULD NOT contain Audio objects * Add that As-Recorded Scripts SHOULD NOT contain Synthesized Audio objects and SHOULD contain Audio Recording objects
cconcolato
reviewed
Sep 25, 2024
Comment on lines
+788
to
+790
| <li>MAY also contain <a>Original</a> <a>Text</a> objects from the <a>Original Language Transcript</a> | ||
| in the case that their language is not the <a>Target Recording Language</a>, | ||
| for context, to assist further processing;</li> |
There was a problem hiding this comment.
I think we should harmonize that text with the one for as-recorded script that uses a different wording.
<li>MAY also contain <a>Original</a> <a>Text</a> objects from
the <a>Original Language Transcript</a>
or <a>Translation</a> <a>Text</a> objects in other languages
for context and quality verification;</li>
There was a problem hiding this comment.
Related issue to this comment: #244.
cconcolato
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75 by implementing the solution we ended up with in the discussion.
Preview | Diff