[web-animations-1] fix code example by handling Animation.finished with .then()
#8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Animation.finished` is a promise and not callable. To attach a handler, use `Animation.finished.then()`, not `Animation.finished()`.
birtles
approved these changes
Jan 23, 2023
|
Hi - is there anything I need to do to make this mergeable? I'm not clear on how the IPR process is supposed to work (though this seems like a non-substantive change to me). |
I'm afraid I'm not sure either. Apparently the staff contact should get a mail about this? (Maybe @svgeesus knows?) I think it's a non-substantive change so I can just admin merge it--I was hoping to find that written down somewhere but I couldn't find it. I asked on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A code example calls
Animation.finished()with a callback function.Animation.finishedis a promise and not callable. This PR changes the code example to useAnimation.finished.then(), notAnimation.finished().