Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restored definition of automatic block sizing pulls in issues related to intrinsic sizes in the block dimension #4231

Closed
dbaron opened this issue Aug 22, 2019 · 4 comments
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits.

Comments

@dbaron
Copy link
Member

dbaron commented Aug 22, 2019

I have one concern about the primary paragraph that was just restored in #4220.

The text of this paragraph seems to unnecessarily redefine the automatic size in the block dimension in a complicated way that pulls in all of the issues in #2890.

It seems to me that the point of the paragraph is to produce a different automatic size in the inline dimension (which is the block dimension of the parent), which is the dimension in which the min-content and max-content concepts are clearly defined. I think it's quite reasonable in that dimension.

In the block dimension, I think the intent of the paragraph is to produce the same rules as the default behavior: the automatic size is the result of layout (since I think the min-content and max-content sizes in the block dimension are supposed to be the same, which makes the fit-content expression given equal to both of them). But it does that by referring to concepts that aren't clearly defined (see #2890) and which might be interpreted in other ways.

I would prefer if this paragraph instead just redefined the automatic size in the inline dimension and left the automatic size in the block dimension alone.

(That said, I'm thinking about this primarily for a display: block orthogonal flow, and haven't really thought through what the automatic sizes are for flex or grid.)

@dbaron dbaron changed the title issues with definition of automatic block sizing restored definition of automatic block sizing pulls in issues related to intrinsic sizes in the block dimension Aug 22, 2019
@fantasai
Copy link
Collaborator

“and left the automatic size in the block dimension alone” means what, exactly?

@dbaron
Copy link
Member Author

dbaron commented Aug 22, 2019

deferring to the existing definition of automatic block size that already exists for its display type

@dbaron
Copy link
Member Author

dbaron commented Aug 22, 2019

IRC discussion

fantasai added a commit that referenced this issue Aug 22, 2019
@fantasai fantasai added the Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. label Aug 22, 2019
@fantasai
Copy link
Collaborator

Verified via IRC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits.
Projects
None yet
Development

No branches or pull requests

2 participants