Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-haspopup at button should not change role #153

Closed
wants to merge 2 commits into from

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Dec 6, 2022

Fixes #51

Changes button so it only becomes a windows buttonmenu with true/menu value for aria-haspopup

Implementation


Preview | Diff

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is consistent with the discussion in the issue and previously opened PR.

@scottaohara
Copy link
Member

outside of the merge conflicts from the big change to how the tables were setup, is there any reason this hasn't been merged?

@spectranaut
Copy link
Contributor

outside of the merge conflicts from the big change to how the tables were setup, is there any reason this hasn't been merged?

Based on our current process, which is a work in progress, normative changes do not land until there is implementation support from two implementations, so it's blocking on that.

@spectranaut
Copy link
Contributor

I made two new labels which maybe we can use to indicate this state :)

@pkra
Copy link
Member

pkra commented May 22, 2024

@jnurthen can you resolve the merge conflicts and push the branch to this repository?

@spectranaut
Copy link
Contributor

Closing, as the PR has been moved: w3c/aria#2205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria-haspopup at button should not change role
5 participants