Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the IRC host and port #2271

Closed
wants to merge 1 commit into from
Closed

Correct the IRC host and port #2271

wants to merge 1 commit into from

Conversation

smockle
Copy link
Contributor

@smockle smockle commented Jul 11, 2024

The ‘joining IRC’ instructions in the onboarding doc do not work as written: IRC Cloud will continually retry, and fail, to connect. This PR corrects the host and port information, plus the link to join.

This PR’s values match the values on https://www.w3.org/Project/IRC/#Server.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit ac47057
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/668fe8b3c27e510008c4ebee
😎 Deploy Preview https://deploy-preview-2271--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and verified these steps work.

@smockle
Copy link
Contributor Author

smockle commented Jul 11, 2024

The Prettier check is failing with Error: A branch or tag with the name 'patch-1' could not be found. This is because it’s looking for this PR’s branch in the w3c/aria repo, not in my fork.

@smockle
Copy link
Contributor Author

smockle commented Jul 15, 2024

The Prettier check is failing with Error: A branch or tag with the name 'patch-1' could not be found. This is because it’s looking for this PR’s branch in the w3c/aria repo, not in my fork.

This is blocking, so I’m closing this PR in favor of #2276, whose source branch is not from a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants