Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redudant config options #1246

Closed
wants to merge 1 commit into from

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Apr 21, 2020

Some options that are not used/supported anymore by ReSpec.

Note, we don't do doRDFa anymore, we doJsonLd now tho :)


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Apr 21, 2020, 1:34 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL


😭  Sorry, there was an error generating the HTML. Please report this issue!
�[36mSpecification: https://rawcdn.githack.com/marcoscaceres/aria/256a91a8c040606866df44f5672d74bfbfd7dd38/index.html?isPreview=true&publishDate=2020-04-21�[39m
�[36mReSpec version: 25.6.0�[39m
�[36mFile a bug: https://github.com/w3c/respec/�[39m
�[36mError: Error: Evaluation failed: Timeout: document.respecIsReady didn't resolve in 0ms.�[39m
�[36m    at ExecutionContext._evaluateInternal (/u/spec-generator/node_modules/puppeteer/lib/ExecutionContext.js:122:13)�[39m
�[36m    at runMicrotasks (<anonymous>)�[39m
�[36m    at processTicksAndRejections (internal/process/task_queues.js:97:5)�[39m
�[36m    at async ExecutionContext.evaluate (/u/spec-generator/node_modules/puppeteer/lib/ExecutionContext.js:48:12)�[39m
�[36m    at async generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:128:12)�[39m
�[36m    at async fetchAndWrite (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:95:18)�[39m
�[36m    at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:14:20)�[39m
�[36m    at async generate (/u/spec-generator/server.js:91:29)�[39m
�[36m  -- ASYNC --�[39m
�[36m    at ExecutionContext.<anonymous> (/u/spec-generator/node_modules/puppeteer/lib/helper.js:111:15)�[39m
�[36m    at DOMWorld.evaluate (/u/spec-generator/node_modules/puppeteer/lib/DOMWorld.js:112:20)�[39m
�[36m    at runMicrotasks (<anonymous>)�[39m
�[36m    at processTicksAndRejections (internal/process/task_queues.js:97:5)�[39m
�[36m  -- ASYNC --�[39m
�[36m    at Frame.<anonymous> (/u/spec-generator/node_modules/puppeteer/lib/helper.js:111:15)�[39m
�[36m    at Page.evaluate (/u/spec-generator/node_modules/puppeteer/lib/Page.js:860:43)�[39m
�[36m    at Page.<anonymous> (/u/spec-generator/node_modules/puppeteer/lib/helper.js:112:23)�[39m
�[36m    at generateHTML (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:128:23)�[39m
�[36m    at runMicrotasks (<anonymous>)�[39m
�[36m    at processTicksAndRejections (internal/process/task_queues.js:97:5)�[39m
�[36m    at async fetchAndWrite (/u/spec-generator/node_modules/respec/tools/respecDocWriter.js:95:18)�[39m
�[36m    at async Object.generate [as respec] (/u/spec-generator/generators/respec.js:14:20)�[39m
�[36m    at async generate (/u/spec-generator/server.js:91:29)�[39m
�[36m�[39m

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

// if you wish the publication date to be other than today, set this
//publishDate: "2014-12-11",
copyrightStart: "2013",
license: "document",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is added automatically by ReSpec, using w3c-software-doc license.

@@ -9,28 +9,20 @@
<script src="common/script/resolveReferences.js" class="remove"></script>
<script class="remove">
var respecConfig = {
// embed RDFa data in the output
trace: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the following are obsolete or not supported.

// specification status (e.g., WD, LC, NOTE, etc.). If in doubt use ED.
specStatus: "ED",
//crEnd: "2012-04-30",
//perEnd: "2013-07-23",
//publishDate: "2013-08-22",
diffTool: "http://www.aptest.com/standards/htmldiff/htmldiff.pl",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-n-cooper michael-n-cooper self-assigned this Apr 21, 2020
michael-n-cooper pushed a commit to w3c/accname that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/aria-practices that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/core-aam that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/css-aam that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/dpub-aam that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/dpub-aria that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/graphics-aam that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/graphics-aria that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/math-aam that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/math-aria that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/mathml-aam that referenced this pull request May 21, 2020
michael-n-cooper pushed a commit to w3c/svg-aam that referenced this pull request May 21, 2020
@michael-n-cooper
Copy link
Member

This change needed to be made in the various ARIA repositories. All changes were accepted except the removal of the "license" property, as a revert to the respec-default W3C Software and Document license would be a normative change and not permitted by the ARIA WG charter. I was not able to edit the pull request for that change so I made a new pull request, in addition to the ones in the other repositories. Note, the respec license documentation does not include the "document" value, even though it is supported by respec and required for some specs.

Pull requests for the rest of the changes from this pull request:

w3c/accname#82
#1274
w3c/aria-practices#1410
w3c/core-aam#72
w3c/css-aam#4
w3c/dpub-aam#2
w3c/dpub-aria#20
w3c/graphics-aam#4
w3c/graphics-aria#6
w3c/html-aam#289
w3c/math-aam#2
w3c/math-aria#2
w3c/mathml-aam#7
w3c/svg-aam#13

michael-n-cooper pushed a commit to w3c/accname that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/core-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/css-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/dpub-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/graphics-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/graphics-aria that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/math-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/math-aria that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/svg-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/dpub-aria that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/mathml-aam that referenced this pull request Jul 10, 2020
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c/aria#1246
michael-n-cooper pushed a commit to w3c/aria-practices that referenced this pull request Jul 13, 2020
michael-n-cooper pushed a commit to w3c/aria-practices that referenced this pull request Jul 13, 2020
respecConfig cleanup (#1410)

from w3c/aria#1246
pkra pushed a commit to pkra/aria that referenced this pull request May 20, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from w3c#1246
pkra pushed a commit that referenced this pull request May 20, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
pkra pushed a commit that referenced this pull request May 20, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
pkra pushed a commit that referenced this pull request May 20, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
pkra pushed a commit that referenced this pull request May 21, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
pkra pushed a commit that referenced this pull request May 21, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
pkra pushed a commit that referenced this pull request May 21, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
pkra pushed a commit that referenced this pull request May 21, 2024
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants