Refactor Actions Menu Button Example Using element.focus() Test Plan to V2 Test Format #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaDC
requested review from
mzgoddard and
mcking65
and removed request for
mzgoddard
|
@mcking65 This Pull Request includes the feedback we discussed in today's CG meeting. |
mcking65
requested changes
Sep 11, 2024
There was a problem hiding this comment.
The example reference points to the activedescendant example in APG instead of to the element.focus example.
In Test 9: Navigate to an item in a menu by typing a character, the VoiceOver command needs to specify that letter quick nav is off.
In the following tests, change priority to 3 for the assertion "convey role of the focused item, 'menu item'":
- Test 4: Open a menu
- Test 5: Open a menu to the last item
|
@mcking65 All done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests