[DO NOT MERGE] Test plan that illustrates assertion exception enhancement specified in issue 1039 #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivedescendant test plan to the V2 test format
…' with 'Navigate forwards to an unchecked radio button'
…he first radio button is checked'
…ToLastUncheckedRadio
…escendant-refactor
Howard's fix to Matt's error Co-authored-by: Howard Edwards <[email protected]>
…escendant-refactor
…n being parsed in test parser
|
#1042 should now make this possible. |
|
Purposed served; #1042 is merged. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
Issue #1039 proposes an enhancement to the logic for assertion exceptions. The first two tests in the radio group test plan in this PR illustrates how that logic would be used.
In the tests.csv file, the assertions for the first test,
navForwardsRadioGroupWhereNoRadioButtonsAreChecked, includes0:interactionModeEnabled. This specifies that the assertioninteractionModeEnabledis not included for any commands associated with this test unless a specific command includes an assertion exception overrides the 0 priority. In jaws-commands.csv and nvda-commands.csv, there is one command associated with this test,tabwith a readingCursor setting, that overrides the priority 0 with priority 2.Similarly, in the test
NavBackIntoRadioGroupWhereLastRadioUnchecked, the assertions column includes:nameThinCrust 0:nameRegularCrustSo, by default, the
nameThinCrustassertion is included for all commands. However, for the shift+tab command, each of the screen reader command files includes the assertionException of:0:nameThinCrust 1:nameRegularCrustThis is because when navigating backward with shift+tab, the cursor moves to the regular curst radio instead of the thin crust radio.
As a result, if #1039 is implemented, the tab and shift+tab commands for these two tests would have assertions that are different from the assertions for other commands.