Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: "Bump into the top edge of a modal dialog" (Modal Dialog Example, Test 8, V24.05.09) #1079

Closed
mcking65 opened this issue Jun 5, 2024 · 3 comments · Fixed by #1080
Assignees
Labels
feedback Issue raised by or for collecting input from people outside the core project team. vo

Comments

@mcking65
Copy link
Contributor

mcking65 commented Jun 5, 2024

Description of Behavior

Test fails because vo-home does not move VoiceOver cursor to the top of the dialog. However, if the cursor is move via other means, the test passes. This test needs to be revised to remove the dependency on a cursor movement command that is not essential to the test.

Test Setup

@mcking65 mcking65 added feedback Issue raised by or for collecting input from people outside the core project team. vo labels Jun 5, 2024
@mcking65
Copy link
Contributor Author

mcking65 commented Jun 5, 2024

Discussed plan to resolve with @IsaDC:

  1. Modify test setup script to place focus on heading at top of dialog.
  2. Remove first command from command sequence.
  3. Make analogous changes to test for bumping into the bottom of the modal dialog.

@css-meeting-bot
Copy link
Member

The ARIA-AT Community Group just discussed Feedback: "Bump into the top edge of a modal dialog" (Modal Dialog Example, Test 8, V24.05.09) · Issue #1079 · w3c/aria-at.

The full IRC log of that discussion <jugglinmike> Subtopic: Feedback: "Bump into the top edge of a modal dialog" (Modal Dialog Example, Test 8, V24.05.09) · Issue #1079 · w3c/aria-at
<jugglinmike> github: https://github.com//issues/1079
<jugglinmike> Matt_King: IsaDC and I have been discussing this offline
<jugglinmike> Matt_King: I've been writing a comment regarding some of my thoughts, but I didn't have time to post that comment prior to this meeting
<jugglinmike> IsaDC: We're going to change the previous test--not only the nested dialog, but also bumping to the top of a "main" dialog?
<jugglinmike> Matt_King: Yeah, we want to change both the top and the bottom.
<jugglinmike> Matt_King: ...but rather than taking up meeting time, I'll add the comment and we can proceed from there

@mcking65
Copy link
Contributor Author

mcking65 commented Jun 5, 2024

@IsaDC, thank you for #1077, which made changes for "Test 12: Bump into the top edge of a Nested modal dialog".
After reviewing the new test plan, I recommend making one more change to test 12 and then making the same set of changes to three additional tests.

First, in test 12, change the instructions. They currently read:

Starting at the 'Address Added' heading inside the nested dialog, navigate to the top of the dialog and make multiple attempts to navigate past the top edge

Please change to:

Starting at the 'Address Added' heading inside the nested dialog, make multiple attempts to navigate past the top edge

Please also mirror the changes to test 12 in the following tests:

  • Test 7: Bump into the bottom edge of a modal dialog
  • Test 8: Bump into the top edge of a modal dialog
  • Test 11: Bump into the bottom edge of a Nested modal dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Issue raised by or for collecting input from people outside the core project team. vo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants