Skip to content

Commit

Permalink
Alert and Radiogroup/activedescendent updates (#865)
Browse files Browse the repository at this point in the history
* Change alert role to optional

* Remove some interaction mode assertions from radiogroup

* Remove some more role/name group assertions
  • Loading branch information
jscholes authored Dec 8, 2022
1 parent 179ba0f commit 0928bcf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions tests/alert/data/tests.csv
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
testId,title,appliesTo,mode,task,setupScript,setupScriptDescription,refs,instructions,assertion1,assertion2,assertion3,assertion4,assertion5,assertion6,assertion7
1,Trigger an alert in reading mode,"JAWS,NVDA",reading,trigger alert,setFocusOnButton,sets focus on the 'Trigger Alert' button,alert,"With the reading cursor on the 'Trigger Alert' button, activate the button to trigger the alert.",Role 'alert' is conveyed,Text 'Hello' is conveyed,,,,,
2,Trigger an alert in interaction mode,"JAWS,NVDA",interaction,trigger alert,setFocusOnButton,sets focus on the 'Trigger Alert' button,alert,"With focus on the 'Trigger Alert' button, activate the button to trigger the alert.",Role 'alert' is conveyed,Text 'Hello' is conveyed,,,,,
3,Trigger an alert,voiceover_macos,interaction,trigger alert,setFocusOnButton,sets focus on the 'Trigger Alert' button,alert,"With focus on the 'Trigger Alert' button, activate the button to trigger the alert.",Role 'alert' is conveyed,Text 'Hello' is conveyed,,,,,
1,Trigger an alert in reading mode,"JAWS,NVDA",reading,trigger alert,setFocusOnButton,sets focus on the 'Trigger Alert' button,alert,"With the reading cursor on the 'Trigger Alert' button, activate the button to trigger the alert.",2:Role 'alert' is conveyed,Text 'Hello' is conveyed,,,,,
2,Trigger an alert in interaction mode,"JAWS,NVDA",interaction,trigger alert,setFocusOnButton,sets focus on the 'Trigger Alert' button,alert,"With focus on the 'Trigger Alert' button, activate the button to trigger the alert.",2:Role 'alert' is conveyed,Text 'Hello' is conveyed,,,,,
3,Trigger an alert,voiceover_macos,interaction,trigger alert,setFocusOnButton,sets focus on the 'Trigger Alert' button,alert,"With focus on the 'Trigger Alert' button, activate the button to trigger the alert.",2:Role 'alert' is conveyed,Text 'Hello' is conveyed,,,,,
12 changes: 6 additions & 6 deletions tests/radiogroup-aria-activedescendant/data/tests.csv
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ testId,title,appliesTo,mode,task,setupScript,setupScriptDescription,refs,instruc
14,Navigate forwards to a checked radio button,VOICEOVER_MACOS,INTERACTION,Navigate forwards to a checked radio button,checkFirstRadioButtonAndSetFocusBeforeRadioGroup,"sets the state of the first radio button to checked, sets focus on a link before the radio group, and hides the group heading",radiogroup aria-labelledby radio aria-checked,"With focus on the 'Navigate forwards from here' link, navigate to the 'Regular crust' radio button.",Role 'group' is conveyed,"Name of the group, 'Pizza Crust', is conveyed",Role 'radio button' is conveyed,"Name of the radio button, 'Regular crust', is conveyed","State of the radio button, 'checked', is conveyed","Position of the radio button, 1, is conveyed","Number of radio buttons in the group, 3, is conveyed"
15,Navigate backwards to a checked radio button in interaction mode,"JAWS,NVDA",INTERACTION,Navigate backwards to a checked radio button,checkFirstRadioButtonAndSetFocusAfterRadioGroup,"sets the state of the first radio button to checked, and sets focus on a link after the radio group",radiogroup aria-labelledby radio aria-checked,"With focus on the 'Navigate backwards from here' link, navigate to the 'Regular crust' radio button.",Role 'group' is conveyed,"Name of the group, 'Pizza Crust', is conveyed",Role 'radio button' is conveyed,"Name of the radio button, 'Regular crust', is conveyed","State of the radio button, 'checked', is conveyed","Position of the radio button, 1, is conveyed","Number of radio buttons in the group, 3, is conveyed"
16,Navigate backwards to a checked radio button,VOICEOVER_MACOS,INTERACTION,Navigate backwards to a checked radio button,checkFirstRadioButtonAndSetFocusAfterRadioGroup,"sets the state of the first radio button to checked, and sets focus on a link after the radio group",radiogroup aria-labelledby radio aria-checked,"With focus on the 'Navigate backwards from here' link, navigate to the 'Regular crust' radio button.",Role 'group' is conveyed,"Name of the group, 'Pizza Crust', is conveyed",Role 'radio button' is conveyed,"Name of the radio button, 'Regular crust', is conveyed","State of the radio button, 'checked', is conveyed","Position of the radio button, 1, is conveyed","Number of radio buttons in the group, 3, is conveyed"
17,Navigate out of the start of a radio group in reading mode,"JAWS,NVDA",READING,Navigate out of the start of a radio group,setFocusOnFirstRadioButton,sets focus on the first radio button,radiogroup aria-labelledby,"With the reading cursor on the 'Regular crust' radio button, navigate to the 'Navigate forwards from here' link.",2:Role 'group' is conveyed,"2:Name of the group, 'Pizza Crust', is conveyed",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate forwards from here' is conveyed,,
18,Navigate out of the start of a radio group in interaction mode,"JAWS,NVDA",INTERACTION,Navigate out of the start of a radio group,setFocusOnFirstRadioButton,sets focus on the first radio button,radiogroup aria-labelledby,"With focus on the 'Regular crust' radio button, navigate to the 'Navigate forwards from here' link.",2:Role 'group' is conveyed,"2:Name of the group, 'Pizza Crust', is conveyed",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate forwards from here' is conveyed,,
19,Navigate out of the start of a radio group,VOICEOVER_MACOS,INTERACTION,Navigate out of the start of a radio group,setFocusOnFirstRadioButton,sets focus on the first radio button,radiogroup aria-labelledby,"With focus on the 'Regular crust' radio button, navigate to the 'Navigate forwards from here' link.",2:Role 'group' is conveyed,"2:Name of the group, 'Pizza Crust', is conveyed",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate forwards from here' is conveyed,,
20,Navigate out of the end of a radio group in reading mode,"JAWS,NVDA",READING,Navigate out of the end of a radio group,setFocusOnThirdRadioButton,sets focus on the third radio button,radiogroup aria-labelledby,"With the reading cursor on the 'Thin crust' radio button, navigate to the 'Navigate backwards from here' link.",2:Role 'group' is conveyed,"2:Name of the group, 'Pizza Crust', is conveyed",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate backwards from here' is conveyed,,
21,Navigate out of the end of a radio group in interaction mode,"JAWS,NVDA",INTERACTION,Navigate out of the end of a radio group,setFocusOnThirdRadioButton,sets focus on the third radio button,radiogroup aria-labelledby,"With focus on the 'Thin crust' radio button, navigate to the 'Navigate backwards from here' link.",2:Role 'group' is conveyed,"2:Name of the group, 'Pizza Crust', is conveyed",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate backwards from here' is conveyed,,
22,Navigate out of the end of a radio group,VOICEOVER_MACOS,INTERACTION,Navigate out of the end of a radio group,setFocusOnThirdRadioButton,sets focus on the third radio button,radiogroup aria-labelledby,"With focus on the 'Thin crust' radio button, navigate to the 'Navigate backwards from here' link.",2:Role 'group' is conveyed,"2:Name of the group, 'Pizza Crust', is conveyed",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate backwards from here' is conveyed,,
17,Navigate out of the start of a radio group in reading mode,"JAWS,NVDA",READING,Navigate out of the start of a radio group,setFocusOnFirstRadioButton,sets focus on the first radio button,radiogroup aria-labelledby,"With the reading cursor on the 'Regular crust' radio button, navigate to the 'Navigate forwards from here' link.",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate forwards from here' is conveyed,,,,
18,Navigate out of the start of a radio group in interaction mode,"JAWS,NVDA",INTERACTION,Navigate out of the start of a radio group,setFocusOnFirstRadioButton,sets focus on the first radio button,radiogroup aria-labelledby,"With focus on the 'Regular crust' radio button, navigate to the 'Navigate forwards from here' link.",Role 'link' is conveyed,name 'Navigate forwards from here' is conveyed,,,,,
19,Navigate out of the start of a radio group,VOICEOVER_MACOS,INTERACTION,Navigate out of the start of a radio group,setFocusOnFirstRadioButton,sets focus on the first radio button,radiogroup aria-labelledby,"With focus on the 'Regular crust' radio button, navigate to the 'Navigate forwards from here' link.",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate forwards from here' is conveyed,,,,
20,Navigate out of the end of a radio group in reading mode,"JAWS,NVDA",READING,Navigate out of the end of a radio group,setFocusOnThirdRadioButton,sets focus on the third radio button,radiogroup aria-labelledby,"With the reading cursor on the 'Thin crust' radio button, navigate to the 'Navigate backwards from here' link.",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate backwards from here' is conveyed,,,,
21,Navigate out of the end of a radio group in interaction mode,"JAWS,NVDA",INTERACTION,Navigate out of the end of a radio group,setFocusOnThirdRadioButton,sets focus on the third radio button,radiogroup aria-labelledby,"With focus on the 'Thin crust' radio button, navigate to the 'Navigate backwards from here' link.",Role 'link' is conveyed,name 'Navigate backwards from here' is conveyed,,,,,
22,Navigate out of the end of a radio group,VOICEOVER_MACOS,INTERACTION,Navigate out of the end of a radio group,setFocusOnThirdRadioButton,sets focus on the third radio button,radiogroup aria-labelledby,"With focus on the 'Thin crust' radio button, navigate to the 'Navigate backwards from here' link.",Group boundary is conveyed,Role 'link' is conveyed,name 'Navigate backwards from here' is conveyed,,,,
23,Read information about an unchecked radio button in reading mode,"JAWS,NVDA",READING,Read information about an unchecked radio button,setFocusOnFirstRadioButton,sets focus on the first radio button,radio aria-activedescendant aria-checked,"With the reading cursor on the 'Regular crust' radio button, read information about the radio button.",Role 'radio button' is conveyed,Name 'Regular crust' is conveyed,State 'unchecked' is conveyed,"2:Position of the radio button, 1, is conveyed","2:Number of radio buttons in the group, 3, is conveyed",,
24,Read information about an unchecked radio button in interaction mode,"JAWS,NVDA",INTERACTION,Read information about an unchecked radio button,setFocusOnFirstRadioButton,sets focus on the first radio button,radio aria-activedescendant aria-checked,"With focus on the 'Regular crust' radio button, read information about the radio button.",Role 'radio button' is conveyed,Name 'Regular crust' is conveyed,State 'unchecked' is conveyed,"Position of the radio button, 1, is conveyed","Number of radio buttons in the group, 3, is conveyed",,
25,Read information about an unchecked radio button,VOICEOVER_MACOS,INTERACTION,Read information about an unchecked radio button,setFocusOnFirstRadioButton,sets focus on the first radio button,radio aria-activedescendant aria-checked,"With focus on the 'Regular crust' radio button, read information about the radio button.",Role 'radio button' is conveyed,Name 'Regular crust' is conveyed,State 'unchecked' is conveyed,"Position of the radio button, 1, is conveyed","Number of radio buttons in the group, 3, is conveyed",,
Expand Down

0 comments on commit 0928bcf

Please sign in to comment.