-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmarks newly copied test plan reports as final during results copy process #974
Merged
alflennik
merged 9 commits into
supportPreservingResultsWithCommandsChanged
from
unmarkCopiedTestPlanReportsAsFinal
Apr 3, 2024
Merged
Unmarks newly copied test plan reports as final during results copy process #974
alflennik
merged 9 commits into
supportPreservingResultsWithCommandsChanged
from
unmarkCopiedTestPlanReportsAsFinal
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
changed the title
Unmarks copied test plan reports during results copy process.
Unmarks copied test plan reports during results copy process
Mar 20, 2024
…t won't be needed depending on when this change goes to production
…kCopiedTestPlanReportsAsFinal
…kCopiedTestPlanReportsAsFinal
…kCopiedTestPlanReportsAsFinal
…kCopiedTestPlanReportsAsFinal
howard-e
changed the title
Unmarks copied test plan reports during results copy process
Unmarks newly copied test plan reports as final during results copy process
Mar 28, 2024
…kCopiedTestPlanReportsAsFinal
alflennik
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! This seems like a positive usability enhancement. Code looks good and I was able to successfully copy data from an old version of Command Button to a new version. 99% of the data was copied which is great.
alflennik
merged commit Apr 3, 2024
2d6b014
into
supportPreservingResultsWithCommandsChanged
2 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the current results copy process, the
markedFinalAt
status is being copied from the older reports. It wouldn't allow the test admin(s) to review the newly copied reports to ensure everything as expected before being displayed on the generated reports again.This PR addresses the following from #935:
Dependent on #967