Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmarks newly copied test plan reports as final during results copy process #974

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Mar 20, 2024

During the current results copy process, the markedFinalAt status is being copied from the older reports. It wouldn't allow the test admin(s) to review the newly copied reports to ensure everything as expected before being displayed on the generated reports again.

This PR addresses the following from #935:

Unmark test plan reports as final once the results have been copied into a new TestPlanVersion's TestPlanReports to make it clearer that the results have been successfully copied. Test administrators will be able to make changes and mark as final again, if appropriate.

Dependent on #967

@howard-e howard-e changed the title Unmarks copied test plan reports during results copy process. Unmarks copied test plan reports during results copy process Mar 20, 2024
@howard-e howard-e marked this pull request as ready for review March 25, 2024 14:26
@howard-e howard-e changed the title Unmarks copied test plan reports during results copy process Unmarks newly copied test plan reports as final during results copy process Mar 28, 2024
@alflennik alflennik self-requested a review April 2, 2024 18:48
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! This seems like a positive usability enhancement. Code looks good and I was able to successfully copy data from an old version of Command Button to a new version. 99% of the data was copied which is great.

@alflennik alflennik merged commit 2d6b014 into supportPreservingResultsWithCommandsChanged Apr 3, 2024
2 checks passed
@alflennik alflennik deleted the unmarkCopiedTestPlanReportsAsFinal branch April 3, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants