Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only include CollectionJob metrics in Bot Status calculation on Test Queue page when tester.isBot is true #1237

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Oct 9, 2024

This PR is to address the case in which a bot run is assigned to a manual user to be evaluated, and then a bot is assigned a run on the same report again. It would cause an aggregation of the assigned bot's and the previously assigned tester's results which would create confusing metrics in the Bot Status calculation, on the Test Queue page.

Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @howard-e, this looks good to me, and it works on my machine. I recognize that we're not convinced that this particular situation (a human user with a collectionJob attribute) ought to be allowed. I added a test anyway because it strengthens the evidence that your patch has the intended effect. Because that makes me the last one to touch this branch, though, I'm going to leave merging to you.

@howard-e
Copy link
Contributor Author

I added a test anyway because it strengthens the evidence that your patch has the intended effect. Because that makes me the last one to touch this branch, though, I'm going to leave merging to you.

Good call! It definitely does. There was a missing collectionJob attribute error being thrown in the console with that added test. So it needed a small fix to include the human's status and testStatus attributes under collectionJob.

Will merge and deploy once the build is successful.

@howard-e howard-e changed the title Check if user is a bot, to include in Bot Status calculation on Test Queue page fix: Only include CollectionJob metrics in Bot Status calculation on Test Queue page when tester.isBot is true Oct 10, 2024
@howard-e howard-e merged commit 84e0bd0 into development Oct 10, 2024
2 checks passed
@howard-e howard-e deleted the stop-counting-user-collectionJobStatus branch October 10, 2024 13:12
howard-e added a commit that referenced this pull request Oct 10, 2024
Create October 10, 2024 Release

Includes the following changes:
* #1237, a follow-up for #1226
@jugglinmike
Copy link
Contributor

Oh, nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In production / Completed
Development

Successfully merging this pull request may close these issues.

2 participants