Additional checks for AtVersion automation run support #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
reviewed
Oct 2, 2024
server/resources/ats.json
Outdated
| { | ||
| "id": 3, | ||
| "name": "VoiceOver for macOS", | ||
| "key": "voiceover_macos", | ||
| "vendorId": 4, |
There was a problem hiding this comment.
Why do we need to define the vendorId property for this patch? Would you mind if I moved JAWS back in order to make the diff clearer?
There was a problem hiding this comment.
Odd, just realized this happened. Looks to be a change included by #1208 that wasn't pushed. That can definitely be done separately
There was a problem hiding this comment.
Removed that change
There was a problem hiding this comment.
Awesome! I'll merge once CI passes
jugglinmike
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1226.
This PR explicitly checks for the AtVersion automation run support in
server/util/getAtVersionWithRequirementswith the already defined valid AtVersion constants instead of using theAtVersion.supportedByAutomationgraphql attribute.This is a quick patch due to the
supportedByAutomationgql attribute not being returned as expected in this instance, while investigations into what may have changed continues.Confirmed tests with this on the sandbox environment.