-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced conflict review [extended] #1197
Conversation
* Changes to pass sandbox deployment issues * Remove explicit install of npm during deploy
…pdown search, ignore Tab (#1196)
* Re-use versionString instead of relying on testPlanVersion.updatedAt (noticed because it wasn't being passed to the created GH Issue)
Thinking on this some more, to retain current behavior from the Test Run page, this should probably be unique to just the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all makes sense to me! Thank you so much for adding it. This is a case of me forgetting to check with a production dump and relying on the limited cases in the default DB.
I am curious if now that we are heavily suggesting the use of a generated template for the issue, we should only enable a 'Raise an Issue' button when there isn't an existing issue. This can be a different discussion and isn't an important point but it feels a bit odd to me to suggest raising an issue that will be largely identical to an existing one.
Very good point there! We can discuss a bit further and certainly a point to raise to others who may be reviewing. |
@stalgiag while doing additional checks on #1195, noticed a few usability concerns that I've addressed in this PR that I had originally missed:
/conflicts
requiredAtVersionName
variable was incorrect. Changed to usingexactAtVersionName