Upgrade puppeteer, fix intermittent CI issues #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
reviewed
Aug 14, 2024
Comment on lines
31
to
35
| await page.waitForNetworkIdle(); | ||
|
|
||
| // Allow additional time for popup to open | ||
| const popupPage = await popupTarget.page(); | ||
| const pages = await global.browser.pages(); | ||
| const popupPage = pages[pages.length - 1]; |
There was a problem hiding this comment.
Interesting! Should the same be done for the similar TestRun.e2e test?
There was a problem hiding this comment.
Good point! It wasn't creating issues so I didn't remember to change it but yes, best to keep consistency. It is changed now.
howard-e
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Looks good! Thanks as well for keeping the puppeteer package up to date. Took a look through their CHANGELOG to see if anything affects this work but that is already reflected in your changes. Being that createIncognitoBrowserContext is now createBrowserContext with the rename happening in v22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the intermittent "Protocol error" issues when e2e testing on GH. The most specific issue this resolves is the one that outputs this error:
This also appears to resolve the issues that appeared as though they were occurring during
yarn installNote that the tests have ran on CI for this a total of 10x times without failing.