Improved atVersion.supportedByAutomation field handling
#1182
Conversation
stalgiag
changed the title
atVersion.supportedByAutomation field handling
| tpr.minimumAtVersion?.id === minimumAtVersion?.id && | ||
| tpr.exactAtVersion?.id === exactAtVersion?.id |
There was a problem hiding this comment.
To the best of my understanding, only one of these may exist at a time so conditionally checking may be good, with exactAtVersion being the priority. Does that change your thoughts on this comparison?
I suppose it shouldn't matter though, since in the instance of the one (exact or minimum) that doesn't exist, undefined === undefined will be evaluated to true anyways anyways.
There was a problem hiding this comment.
Yeah I think it still makes sense because we are ensuring the Reports are a match and so if one has an undefined minimum then the other would as well. One or the other is going to be a useless check since having only a minimum or a required is probably enforced elsewhere but I think it is a lower cognitive load to read than doing an OR between those two.
There was a problem hiding this comment.
Fair enough on the cognitive load, this is fine with me.
server/resolvers/AtVersion/index.js
Outdated
| const supportedByAutomationResolver = require('./supportedByAutomationResolver'); | ||
|
|
||
| const AtVersion = { | ||
| supportedByAutomation: supportedByAutomationResolver |
There was a problem hiding this comment.
nit: just for consistency, the other files in /resolvers import the resolver as the expected attribute name, so const supportedByAutomation = require('./supportedByAutomationResolver');
This PR adds a custom resolver for
atVersion.supportedByAutomationthat uses caching.