-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic snapshot testing #1175
Basic snapshot testing #1175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In acknowledging that this is an extra layer of maintenance and developing of new features, it's also a huge plus in ensuring the accuracy of such a data heavy system. Kudos for getting this going! Looks good to me!
I've left only a small inline comment but feel free to merge when ready.
client/tests/e2e/snapshots/utils.js
Outdated
// Remove href and version number on data management page | ||
// Addresses inconsistent links and date -> version number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A think a TODO should be included for ones like this so we can explore and remove this cleaner when necessary, explaining what the issue is.
There certainly shouldn't be a mismatch with the version dates being displayed no matter the environment.
'<span class="full-width"><a><span><svg>...</svg><b>VERSION_REMOVED</b></span></a></span>' | ||
); | ||
|
||
// Strip out randomly generated IDs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
* Attempt to fix date discrepancy in snapshot testing * Attempt to use UTC for date calculation in all cases * Correct update for utc snapshots * Further expand tested dates with utc normalization * Add TODO comments
This PR introduces basic snapshot testing for each major route.
Notes:
clients/tests/e2e/snapshots/util.js
. Some of these may be removed after the underlying inconsistency is investigated.