Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permit automated testing for firefox and chrome with voiceover #1170

Merged
merged 3 commits into from
Jul 25, 2024
Merged

permit automated testing for firefox and chrome with voiceover #1170

merged 3 commits into from
Jul 25, 2024

Conversation

outofambit
Copy link
Contributor

@outofambit outofambit commented Jul 22, 2024 •
edited
Loading

This PR addresses #1171

  • updates logic to allow running automated tests for voiceover with firefox and chrome
  • adds ability to pass test-ids into modal component buttons
  • updates test for user flow changes with new browser support

@outofambit outofambit marked this pull request as ready for review July 23, 2024 19:19
@outofambit outofambit changed the title permit firefox and chrome with voiceover permit automated testing for firefox and chrome with voiceover Jul 23, 2024
howard-e
howard-e approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

stalgiag
stalgiag approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the full loop locally and everything works as expected. Thank you 🎊

@stalgiag stalgiag merged commit 9c73ab5 into development Jul 25, 2024
2 checks passed
@stalgiag stalgiag deleted the voiceover-with-firefox-chrome-support branch July 25, 2024 20:58
@howard-e howard-e mentioned this pull request Jul 29, 2024
Merged
howard-e added a commit that referenced this pull request Jul 29, 2024
@howard-e
Merge pull request #1178 from w3c/development
1812f84 
Create July 29, Release

Includes the following changes:

* #1172, to address #1173 and #1174
* #1170, to address #1171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

@stalgiag stalgiag stalgiag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@outofambit @howard-e @stalgiag